Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gs1.1 opportunistic grafting #96

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

wemeetagain
Copy link
Member

Implements https://github.com/libp2p/specs/blob/master/pubsub/gossipsub/gossipsub-v1.1.md#opportunistic-grafting

Depends on #95
Follows go-libp2p-pubsub implementation

Only one block of code in heartbeat added

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2020

Codecov Report

Merging #96 into gsv1.1 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           gsv1.1      #96   +/-   ##
=======================================
  Coverage   81.81%   81.81%           
=======================================
  Files           1        1           
  Lines          11       11           
=======================================
  Hits            9        9           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1407cd9...cbee3a2. Read the comment docs.

@wemeetagain wemeetagain force-pushed the cayman/gs1.1-opportunistic-grafting branch from 13dc48b to cbee3a2 Compare June 23, 2020 17:01
Copy link
Collaborator

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ts/heartbeat.ts Show resolved Hide resolved
@wemeetagain wemeetagain merged commit b2bdb13 into gsv1.1 Jun 23, 2020
@wemeetagain wemeetagain deleted the cayman/gs1.1-opportunistic-grafting branch June 23, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants