Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirects to new docs pages do not work #6885

Open
nflaig opened this issue Jun 13, 2024 · 2 comments · Fixed by #6940
Open

Redirects to new docs pages do not work #6885

nflaig opened this issue Jun 13, 2024 · 2 comments · Fixed by #6940
Labels
scope-documentation All issues related to the Lodestar documentation.

Comments

@nflaig
Copy link
Member

nflaig commented Jun 13, 2024

As noted in 966f3ac#r143045200, it seems like the redirect do not work as expected.

I also found a few warnings related to that when running docusaurus build

[WARNING] @docusaurus/plugin-client-redirects: some redirects would override existing paths, and will be ignored:
- {"from":"/run/beacon-management/beacon-cli","to":"/beacon-management/beacon-cli"}
- {"from":"/run/bootnode/bootnode-cli","to":"/bootnode/bootnode-cli"}
- {"from":"/libraries/lightclient-prover/lightclient-cli","to":"/lightclient-prover/lightclient-cli"}
- {"from":"/run/validator-management/validator-cli","to":"/validator-management/validator-cli"}
@nflaig nflaig added the scope-documentation All issues related to the Lodestar documentation. label Jun 13, 2024
@nflaig
Copy link
Member Author

nflaig commented Jul 9, 2024

While #6940 fixed redirects locally, they are still broken when docs are deployed to https://chainsafe.github.io/lodestar/. Needs further investigation

@nflaig nflaig reopened this Jul 9, 2024
@nflaig
Copy link
Member Author

nflaig commented Jul 9, 2024

Questionable if we need those redirects anyways, looking at external references that are broken e.g. on https://launchpad.ethereum.org/en/lodestar, most of those still reference pages before initial restructuring we did way earlier, and those are not handled by the docusaurus redirects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope-documentation All issues related to the Lodestar documentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant