Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] configurable **client** certificate #3935

Open
pnck opened this issue Jan 27, 2024 · 3 comments
Open

[Feature] configurable **client** certificate #3935

pnck opened this issue Jan 27, 2024 · 3 comments
Labels
backlog help wanted Extra attention is needed

Comments

@pnck
Copy link

pnck commented Jan 27, 2024

Hi, I encountered a problem with the client certificate verifying / authenticating.

When enabled client certs (typically the Cloudflare mTLS rules), the client must present its private cert (aka .p12/.pfx file) to the server. However since ChatGPT-Next-Web requests the API base from the backend, it would not carry the valid credentials that should have come from a browser request.

So there should be a configurable option to specify a client certificate so that the mutual verification would work.

I have read the issue list and found that #518 #3034 may be related, but both of them didn't mention if it's possible to deploy a client certificate for the backend.

My current approach is to allow the server IP as request src_ip, but it's quite inconvenient since I had to hard code the IP into the rules. So let me ask for a feature to satisfy this scene.

@fred-bf
Copy link
Contributor

fred-bf commented Feb 1, 2024

Hi, we currently have no plans to support client certificate validation, and we expect to meet the current authentication requirements through the user system in the future

@pnck
Copy link
Author

pnck commented Feb 1, 2024

@fred-bf You might misunderstand. In this case it's the ChatGPT API Server (typically any API proxy) that requires the client (i.e. the ChatGPT-Next-Web server ) to be verified. There is nothing about checking certificates by ChatGPT-Next-Web itself.

I was looking forward to getting the ChatGPT-Next-Web backend to send HTTPS requests with p12/pfx credentials. Any hints are appreciated.

@fred-bf
Copy link
Contributor

fred-bf commented Feb 10, 2024

@pnck Get it. This is not currently on the mainline feature that we support, but I understand the rationality of this feature, so I'll mark it into the backlog for the time being.

@fred-bf fred-bf added help wanted Extra attention is needed backlog labels Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants