Fix #923

[xinbenlv]

Fixes #923

[huan]

Awesome! Could you please fix the CI linting error before we could merge it?

https://travis-ci.org/Chatie/wechaty/jobs/294637040#L650

[huan]

ping @xinbenlv Please fix the linting error so that we could merge it, thanks! :)

[lijiarui]

Change wechaty function to the latest one.

[lijiarui]

The latest wechaty function is stop(), maybe we should change the latest one instead.

[lijiarui]

await bot.stop()

[lijiarui]

maybe it should add bot.stop() and process.exit(-1)here, or chrome will restart again and again... and node cannot be quit.... see #978

[huan]

ping @xinbenlv

[xinbenlv]

I am using this feature (hot-import) and start to experience some problem, mostly due to the cache was not cleared and watch function not triggered, so when I update code, it was not being refreshed. Have you experienced it? zhuohuan, can you provide an example demonstrating how hot-import can load a class inside of a module? (decouple from WeChaty)? Thank you!

…

On Wed, Nov 22, 2017 at 7:02 PM, Huan LI ***@***.***> wrote: ping @xinbenlv <https://github.com/xinbenlv> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#935 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAnFRTzOR3mLRHdruCER0ag4olzx_xSeks5s5OA0gaJpZM4QKiya> .

[xinbenlv]

I think before we can solve this, it doesn't help much (and can mislead people if we provide this example code for WeChaty)

…

On Wed, Nov 22, 2017 at 7:37 PM, Zainan Victor Zhou ***@***.***> wrote: I am using this feature (hot-import) and start to experience some problem, mostly due to the cache was not cleared and watch function not triggered, so when I update code, it was not being refreshed. Have you experienced it? zhuohuan, can you provide an example demonstrating how hot-import can load a class inside of a module? (decouple from WeChaty)? Thank you! On Wed, Nov 22, 2017 at 7:02 PM, Huan LI ***@***.***> wrote: > ping @xinbenlv <https://github.com/xinbenlv> > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#935 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AAnFRTzOR3mLRHdruCER0ag4olzx_xSeks5s5OA0gaJpZM4QKiya> > . >

[huan]

I did not use hotImport lot but it always works fine with me.

In order to import a class, you can have a look into https://github.com/zixia/hot-import/blob/bc380c8238d3f7e1d410fd21d5e404de4aa8760e/src/hot-import.spec.ts#L82

The unit tests & fixtures would help you understand the inside logic, and please file issue if you meet any bug.

Thanks.

[suntong]

@xinbenlv

I am using this feature (hot-import) and start to experience some problem...

do you have more updates on that please?

Have you tried https://github.com/Chatie/wechaty/tree/master/example/hot-reload-bot?

@zixia, what's the difference between the hot-reload-bot demo and hot-import?

Thanks

[huan]

@suntong I had just written a new example of how to use hot-import feature which natively supported by Wechaty at here: https://github.com/Chatie/wechaty/tree/master/example/hot-import-bot

Hope that could help you.

@xinbenlv Please have a look at it too, I tested it and felt it works well. thanks.

Good luck!

[suntong]

ha, I see your new changes right in front of my eyes, from your own to @xinbenlv's PR. :-)

So, @xinbenlv & @zixia, I looked at the

https://github.com/Chatie/wechaty/blob/master/example/hot-import-bot/index.js and
https://github.com/Chatie/wechaty/blob/master/example/hot-import-bot/listeners/on-message.js

but can't find where hot-import is utilized. can you point out to me where please?

[huan]

@suntong See:

https://github.com/Chatie/wechaty/blob/b5c0c14fc2633de1e03405764eeb73554939400e/src/wechaty.ts#L366-L384

[suntong]

Oh, it's now completely embedded into the core code so no external fiddling necessary. Cool.

Ok, then, how to make use of the feature to load config files? Thx.

[huan]

@suntong Sorry it's only the hot-import for the module is supported by the core code.

You still have to do load config files job by yourself.

[suntong]

OK. I'll try hot-importing them myself via the API... thx.

[suntong]

@xinbenlv,

How do you start this demo, apart from running from docker?

I tried both node index.js and ts-node index.js but the results are the same:

20:15:06 ERR HotImport importFile(/.../wechaty/example/hot-import-bot/listeners/on-friend.js) rejected: SyntaxError: Unexpected token export
20:15:06 ERR HotImport importFile(/.../wechaty/example/hot-import-bot/listeners/on-login.js) rejected: SyntaxError: Unexpected token export
...
export default async function onFriend (contact, request) {
^^^^^^
SyntaxError: Unexpected token export
...

thanks!