Split list of emote sets into bunches when performing Ivr API reqeusts #2856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mm2PL
approved these changes
Jun 5, 2021
pajlada
approved these changes
Jun 6, 2021
zneix
added a commit
to SevenTV/chatterino7
that referenced
this pull request
Jun 6, 2021
Now we're on commit 2f568b8; Changes from upstream we pulled: - Minor: Searching for users in the viewer list now searches anywhere in the user's name. (Chatterino#2861) - Minor: Now shows deletions of messages like timeouts (Chatterino#1155, Chatterino#2841) - Minor: Added a link to accounts page in settings to "You need to be logged in to send messages" message. (Chatterino#2862) - Minor: Switch to Twitch v2 emote API for animated emote support. (Chatterino#2863) - Bugfix: Fix reconnecting when IRC write connection is lost (Chatterino#1831, Chatterino#2356, Chatterino#2850) - Bugfix: Fixed bit emotes not loading in some rare cases. (Chatterino#2856)
zneix
added a commit
that referenced
this pull request
Jun 6, 2021
zneix
added a commit
that referenced
this pull request
Jun 6, 2021
zneix
added a commit
to SevenTV/chatterino7
that referenced
this pull request
Jun 19, 2021
Now we're on commit d6b5921; Changes from upstream we pulled: - Major: Added username autocompletion popup menu when typing usernames with an @ prefix. (Chatterino#1979, Chatterino#2866) - Minor: The /live split now shows channels going offline. (Chatterino#2880) - Minor: Now shows deletions of messages like timeouts (Chatterino#1155, Chatterino#2841, Chatterino#2867, Chatterino#2874) - Bugfix: Moderation buttons now show the correct time unit when using units other than seconds. (Chatterino#1719, Chatterino#2864) - Bugfix: Fixed bit and new subscriber emotes not (re)loading in some rare cases. (Chatterino#2856, Chatterino#2857)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Added a helper vector of vectors and some logic that splits QStringList that we receive as a function parameter to avoid getting 400's from Ivr API as it supports fetching 100 emote sets at max.
One unrelated change: updated a link to Ivr API endpoint we're using because it has changed.
P.S. Thanks @talneoran for helping to come up with the solution