Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emote picker window stays open when deleting words with Ctrl + Backspace #2780

Closed
jupjohn opened this issue May 14, 2021 · 7 comments · Fixed by #2781
Closed

Emote picker window stays open when deleting words with Ctrl + Backspace #2780

jupjohn opened this issue May 14, 2021 · 7 comments · Fixed by #2781
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user issue-report An issue reported by a user.

Comments

@jupjohn
Copy link
Contributor

jupjohn commented May 14, 2021 •
edited

Describe your issue
When using the : emote picker and using Ctrl + Backspace to delete the text + colon the emote picker window stays active.
Pressing escape does close the window.

Screenshots

Chatterino2_Bug_CtrlBackspaceEmotePicker.mp4

OS and Chatterino Version
Arch Linux (btw), Linux Zen 5.12.3-zen
Chatterino 2.3.1 (commit 2ea233a)
@jupjohn jupjohn added the issue-report An issue reported by a user. label May 14, 2021
@Felanbird
Copy link
Collaborator

can replicate

win10 d59bb80

@jupjohn
Copy link
Contributor Author

jupjohn commented May 14, 2021 •
edited

On further investigation it seems that QTextEdit::cursorPositionChanged doesn't signal from the input when pressing Ctrl + Backspace. Could be a QT quirk I'm not aware of.

https://github.com/Chatterino/chatterino2/blob/master/src/widgets/splits/SplitInput.cpp#L87

@jupjohn jupjohn mentioned this issue May 14, 2021
Merged
1 task
@Mm2PL
Copy link
Collaborator

Mm2PL commented May 14, 2021 •
edited

Can reproduce only when I type an emote prefix that exists, ex:

  • :penis<C-BS><C-BS> does not have this behavior
  • while :sad<C-BS><C-BS> has

@Felanbird
Copy link
Collaborator

Can reproduce only when I type an emote prefix that exists, ex:

  • :penis<C-BS><C-BS> does not have this behavior
  • while :sad<C-BS><C-BS> has

I'm able to reproduce when using a non existent prefix, even using ~ as the prefix which would obviously have nothing, works.

@jupjohn
Copy link
Contributor Author

jupjohn commented May 14, 2021

I'm able to reproduce when using a non existent prefix, even using ~ as the prefix which would obviously have nothing, works.

Same here.

@Mm2PL
Copy link
Collaborator

Mm2PL commented May 14, 2021

I retested just to make sure and this time I am able to reproduce with non-existent prefixes fuck me.png

@Felanbird
Copy link
Collaborator

I retested just to make sure and this time I am able to reproduce with non-existent prefixes fuck me.png

Good I almost said "Ubuntu master race I guess..."

@pajlada pajlada added the bug Something isn't working as intended, or works in a confusing/unintuitive way for the user label May 15, 2021
GabeEddyT added a commit to GabeEddyT/chatterino2 that referenced this issue May 25, 2021
@GabeEddyT
Merge tag 'v2.3.2' into feature/pronouns
0dce960 
Release v2.3.2

- Major: New split for channels going live! /live. (Chatterino#1797)
- Minor: Added a message that displays a new date on new day. (Chatterino#1016)
- Minor: Hosting messages are now clickable. (Chatterino#2655)
- Minor: Messages held by automod are now shown to the user. (Chatterino#2626)
- Minor: Load 100 blocked users rather than the default 20. (Chatterino#2772)
- Bugfix: Fixed a potential crashing issue related to the browser extension. (Chatterino#2774)
- Bugfix: Strip newlines from stream titles to prevent text going off of split header (Chatterino#2755)
- Bugfix: Automod messages now work properly again. (Chatterino#2682)
- Bugfix: `Login expired` message no longer highlights all tabs. (Chatterino#2735)
- Bugfix: Fix a deadlock that would occur during user badge loading. (Chatterino#1704, Chatterino#2756)
- Bugfix: Tabbing in `Select a channel to open` is now consistent. (Chatterino#1797)
- Bugfix: Fix Ctrl + Backspace not closing colon emote picker. (Chatterino#2780)
- Bugfix: Approving/denying AutoMod messages works again. (Chatterino#2779)
- Dev: Migrated AutoMod approve/deny endpoints to Helix. (Chatterino#2779)
- Dev: Migrated Get Cheermotes endpoint to Helix. (Chatterino#2440)

# gpg: directory '/c/Users/gtroy/.gnupg' created
# gpg: keybox '/c/Users/gtroy/.gnupg/pubring.kbx' created
# gpg: Signature made Sun May 16 15:05:25 2021 EDT
# gpg:                using RSA key 16CA5983F9FDD6EB599AAA70911916E0523B22F6
# gpg: Can't check signature: No public key

# Conflicts:
#	src/widgets/settingspages/GeneralPage.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user issue-report An issue reported by a user.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix word backspacing not closing/updating colon emote picker jupjohn/jammerino
4 participants
@pajlada @jupjohn @Mm2PL @Felanbird