Load 100 blocked users instead of default 20 #2772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For some wild reason the "count" is actually called "first". Haven't tested but should work. https://dev.twitch.tv/docs/api/reference#get-user-block-list |
|
I think that following pagination to load all the blocks is a better solution, however this is better than nothing. |
|
Might be nicer to paginate the blocked users page so that we can return a decent chunk. Might be too bloated for current settings layout though |
Pagination would definitely be what we want to do, but even with a pagination PR we'd want to increase the limit to 100 so this is a good first step |
pajlada
approved these changes
May 14, 2021
zneix
approved these changes
May 14, 2021
zneix
changed the title
vaehx
added a commit
to vaehx/chatterino2
that referenced
this pull request
May 16, 2021
* chatterino/master: Add setting to disable custom ffz mod/VIP badges (Chatterino#2759) v2.3.2 added try catch in nm (Chatterino#2785) Fixed deprecated method Qt::SystemLocaleLongDate (Chatterino#2784) Migrated cheermotes to Helix API (Chatterino#2440) Fix word backspacing not closing/updating colon emote picker (Chatterino#2781) Load 100 blocked users instead of default 20 (Chatterino#2772) Refactored and Migrated to Helix AutoMod message management (Chatterino#2779) Add flatpak version badge (Chatterino#2782) Bump dangoslen/changelog-enforcer from 2.1.0 to 2.2.0 (Chatterino#2770) Bump ilammy/msvc-dev-cmd from 1.7.0 to 1.8.0 (Chatterino#2769)
GabeEddyT
added a commit
to GabeEddyT/chatterino2
that referenced
this pull request
May 25, 2021
Release v2.3.2 - Major: New split for channels going live! /live. (Chatterino#1797) - Minor: Added a message that displays a new date on new day. (Chatterino#1016) - Minor: Hosting messages are now clickable. (Chatterino#2655) - Minor: Messages held by automod are now shown to the user. (Chatterino#2626) - Minor: Load 100 blocked users rather than the default 20. (Chatterino#2772) - Bugfix: Fixed a potential crashing issue related to the browser extension. (Chatterino#2774) - Bugfix: Strip newlines from stream titles to prevent text going off of split header (Chatterino#2755) - Bugfix: Automod messages now work properly again. (Chatterino#2682) - Bugfix: `Login expired` message no longer highlights all tabs. (Chatterino#2735) - Bugfix: Fix a deadlock that would occur during user badge loading. (Chatterino#1704, Chatterino#2756) - Bugfix: Tabbing in `Select a channel to open` is now consistent. (Chatterino#1797) - Bugfix: Fix Ctrl + Backspace not closing colon emote picker. (Chatterino#2780) - Bugfix: Approving/denying AutoMod messages works again. (Chatterino#2779) - Dev: Migrated AutoMod approve/deny endpoints to Helix. (Chatterino#2779) - Dev: Migrated Get Cheermotes endpoint to Helix. (Chatterino#2440) # gpg: directory '/c/Users/gtroy/.gnupg' created # gpg: keybox '/c/Users/gtroy/.gnupg/pubring.kbx' created # gpg: Signature made Sun May 16 15:05:25 2021 EDT # gpg: using RSA key 16CA5983F9FDD6EB599AAA70911916E0523B22F6 # gpg: Can't check signature: No public key # Conflicts: # src/widgets/settingspages/GeneralPage.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Work towards #2767 so that at least up to 100 blocked users are returned rather than the default 20