Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chatterino window is too tall (for other apps) on Windows #5048

Closed
4 tasks done
Nerixyz opened this issue Dec 28, 2023 · 0 comments · Fixed by #4868
Closed
4 tasks done

Chatterino window is too tall (for other apps) on Windows #5048

Nerixyz opened this issue Dec 28, 2023 · 0 comments · Fixed by #4868
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user OS: Windows

Comments

@Nerixyz
Copy link
Contributor

Nerixyz commented Dec 28, 2023

Checklist

  • I'm reporting a problem with Chatterino
  • I've verified that I'm running the most recent nightly build or stable release
  • I've looked for my problem on the wiki
  • I've searched the issues and pull requests for similar looking reports

Describe your issue

When taking a screenshot of Chatterino with ShareX, the detected bounds are too large (see screenshot). This is a bug in Chatterino, not ShareX.

In normal window placement (non-maximized), the window is 1px too tall. When maximized, the window is 8px too tall (or rather: dpr * 8px).

This is caused by the added margins.

Since Telegram seems to get this right (source), I used their handler in try/nccalcsize. I added that fix to my dpi branch locally (as they both modify the same code). I'll push some day.

Linking to #4868 and #3690 which both touch related code. I could probably integrate that into my PR, since it already removes the resize-fixing.

Screenshots

Maximized:

OS and Chatterino Version

Chatterino Nightly 7.4.5 (commit 2abb9c3) built on 2023-09-17 with Qt 6.5.0, MSVC 193732822 Running on Windows 10 Version 22H2, kernel: 10.0.19045

@Nerixyz Nerixyz added the issue-report An issue reported by a user. label Dec 28, 2023
@Felanbird Felanbird added bug Something isn't working as intended, or works in a confusing/unintuitive way for the user OS: Windows and removed issue-report An issue reported by a user. labels Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user OS: Windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants