Fixed zooming bug in native-host-ext [Chrome] #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ALazyMeme
suggested changes
Sep 4, 2020
There was a problem hiding this comment.
Edit: Don't mind me
The below needs to be changed, I'd like to be able to reproduce the bug before I can approve. As per my comment - could you please advise steps to reproduce this bug?
Co-authored-by: alazymeme <jkeasley@icloud.com>
23rd
reviewed
Sep 24, 2020
|
Can someone verify that this works? Also check with hi-dpi enabled in windows. I don't have time to check this myself. |
I can check, just need some form of a comment or change in regards to #1936 (comment) and then I'll test it again |
Haven't tested this, but it looks good 👌🏼 Co-authored-by: 23rd <23rd@vivaldi.net>
|
Is this fix still needed or can it be closed? |
ALazyMeme
approved these changes
Jul 11, 2021
|
Confirmed the new chatterino build from this pr works just fine with the normal extension (without the zoom-related updated). |
|
@pajlada merge pls |
pajlada
approved these changes
Jul 25, 2021
pajlada
approved these changes
Jul 25, 2021
zneix
added a commit
to SevenTV/chatterino7
that referenced
this pull request
Jul 25, 2021
Now we're on commit 770b9f2; Changes from upstream we pulled: - Minor: Added informative messages for recent-messages API's errors. (Chatterino#3029) - Minor: Added section with helpful Chatterino-related links to the About page. (Chatterino#3068) - Bugfix: Fixed PubSub not properly trying to resolve pending listens when the pending listens list was larger than 50. (Chatterino#3037) - Bugfix: Copy buttons in usercard now show properly in light mode (Chatterino#3057) - Bugfix: Fixed comma appended to username completion when not at the beginning of the message. (Chatterino#3060) - Bugfix: Fixed bug misplacing chat when zooming on Chrome with Chatterino Native Host extension (Chatterino#1936) - Dev: Disabled update checker on Flatpak. (Chatterino#3051) - Dev: Add logging for HTTP requests (Chatterino#2991)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Fixed a bug that misplaced the attached window when zooming on Chrome. Now gets pixel ratio data from the extension to determine the proper x location of chat. Still supports extension versions 1.2 and 1.3.
Requires: Chatterino/chatterino-browser-ext#28