Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed comma appended to username completion when not at the beginning of the message #3060

Merged
merged 4 commits into from
Jul 24, 2021

Conversation

zneix
Copy link
Collaborator

@zneix zneix commented Jul 22, 2021

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Fixes issue described in #2918. As discussed with other people in chat, I've also went ahead and made right-clicking "username links" follow the same format of appending comma after the username only if it's the first word.

@Mm2PL Mm2PL self-requested a review July 22, 2021 19:43
Copy link
Collaborator

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works as intended 👍

@zneix zneix changed the title Fixed comma appended with user input completion Fixed comma appended to username completion when not at the beginning of the message Jul 22, 2021
@zneix zneix requested a review from Mm2PL July 22, 2021 21:00
@zneix zneix merged commit 588ed55 into master Jul 24, 2021
@zneix zneix deleted the zneix/fix/comma-at-mention-end branch July 24, 2021 10:01
zneix added a commit to SevenTV/chatterino7 that referenced this pull request Jul 25, 2021
Now we're on commit 770b9f2; Changes from upstream we pulled:

- Minor: Added informative messages for recent-messages API's errors. (Chatterino#3029)
- Minor: Added section with helpful Chatterino-related links to the About page. (Chatterino#3068)
- Bugfix: Fixed PubSub not properly trying to resolve pending listens when the pending listens list was larger than 50. (Chatterino#3037)
- Bugfix: Copy buttons in usercard now show properly in light mode (Chatterino#3057)
- Bugfix: Fixed comma appended to username completion when not at the beginning of the message. (Chatterino#3060)
- Bugfix: Fixed bug misplacing chat when zooming on Chrome with Chatterino Native Host extension (Chatterino#1936)
- Dev: Disabled update checker on Flatpak. (Chatterino#3051)
- Dev: Add logging for HTTP requests (Chatterino#2991)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants