Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added section with helpful Chatterino-related links to the About page #3068

Merged
merged 14 commits into from
Jul 25, 2021

Conversation

xHeaveny
Copy link
Contributor

@xHeaveny xHeaveny commented Jul 24, 2021

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Added section with helpful Chatterino-related links to the About page.
Closes #2965

@xHeaveny xHeaveny changed the title xHeaveny/add/wiki/about "About Chatterino" to About tab Jul 24, 2021
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have the links defined at the top of this file as constexpr strings or something along those lines to make future changes easier

@xHeaveny xHeaveny requested a review from pajlada July 24, 2021 11:50
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would still like the links in a constexpr or define at the top of the file, and the formatting seems to fail so please check your clang-format

CHANGELOG.md Outdated Show resolved Hide resolved
@pajlada
Copy link
Member

pajlada commented Jul 25, 2021

Another request: Please put the "About Chatterino" section above "Open source software used"

@xHeaveny xHeaveny requested a review from pajlada July 25, 2021 12:48
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final changes (I think)

src/widgets/settingspages/AboutPage.cpp Outdated Show resolved Hide resolved
src/widgets/settingspages/AboutPage.cpp Outdated Show resolved Hide resolved
Co-authored-by: pajlada <rasmus.karlsson@pajlada.com>
@pajlada pajlada enabled auto-merge (squash) July 25, 2021 13:42
CHANGELOG.md Outdated Show resolved Hide resolved
@zneix zneix disabled auto-merge July 25, 2021 13:54
@zneix zneix changed the title "About Chatterino" to About tab Added section with helpful Chatterino-related links to the About page Jul 25, 2021
@zneix zneix enabled auto-merge (squash) July 25, 2021 13:55
@zneix zneix merged commit 33d1837 into Chatterino:master Jul 25, 2021
zneix added a commit to SevenTV/chatterino7 that referenced this pull request Jul 25, 2021
Now we're on commit 770b9f2; Changes from upstream we pulled:

- Minor: Added informative messages for recent-messages API's errors. (Chatterino#3029)
- Minor: Added section with helpful Chatterino-related links to the About page. (Chatterino#3068)
- Bugfix: Fixed PubSub not properly trying to resolve pending listens when the pending listens list was larger than 50. (Chatterino#3037)
- Bugfix: Copy buttons in usercard now show properly in light mode (Chatterino#3057)
- Bugfix: Fixed comma appended to username completion when not at the beginning of the message. (Chatterino#3060)
- Bugfix: Fixed bug misplacing chat when zooming on Chrome with Chatterino Native Host extension (Chatterino#1936)
- Dev: Disabled update checker on Flatpak. (Chatterino#3051)
- Dev: Add logging for HTTP requests (Chatterino#2991)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

General wiki link
3 participants