New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting to disable custom ffz mod/VIP badges #2759
Conversation
I'd rather have a dropdown menu where you enable the custom badges.
(Before you implement it it'd be better if someone else has an opinion on this) For example I think some of the VIP badges are stupid so I'd make sense to disable them while moderator badges you can always tell that they are moderator badges. |
i feel like the "bot" badge from ffz/bttv should be implemented too. |
That's a separate issue. |
In the long run a dropdown with a string value won't make sense so it's more worth keeping the settings as 'single values', even though it will add a bit more clutter now it can be cleaned up the future if another value were to be added. tl;dr: 2 checkboxes > 1 dropdown menu imo. Setting scope is fine, setting position we've chatted about but it can be added after a separator in the "Visible badges" category |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👌
* chatterino/master: Add setting to disable custom ffz mod/VIP badges (Chatterino#2759) v2.3.2 added try catch in nm (Chatterino#2785) Fixed deprecated method Qt::SystemLocaleLongDate (Chatterino#2784) Migrated cheermotes to Helix API (Chatterino#2440) Fix word backspacing not closing/updating colon emote picker (Chatterino#2781) Load 100 blocked users instead of default 20 (Chatterino#2772) Refactored and Migrated to Helix AutoMod message management (Chatterino#2779) Add flatpak version badge (Chatterino#2782) Bump dangoslen/changelog-enforcer from 2.1.0 to 2.2.0 (Chatterino#2770) Bump ilammy/msvc-dev-cmd from 1.7.0 to 1.8.0 (Chatterino#2769)
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
Adds a toggle setting that allows disabling using the custom FFZ moderator and VIP badges.
Currently implemented as one setting for both, to avoid more settings, and is enabled by default.
Currently not sure about:
Closes #2693