Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to disable custom ffz mod/VIP badges #2759

Merged
merged 8 commits into from
May 16, 2021

Conversation

talneoran
Copy link
Contributor

@talneoran talneoran commented May 8, 2021

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Adds a toggle setting that allows disabling using the custom FFZ moderator and VIP badges.
Currently implemented as one setting for both, to avoid more settings, and is enabled by default.

Currently not sure about:

  • The location of the setting in the menu and in the settings file.
  • Other badge settings update old messages when changed, for example disabling the Chatterino badge setting will remove that badge from already existing messages in chat. However, due to how the current implementation works, this setting doesn't update on old messages, and will only change whether or not the custom badges are used for new messages. Not sure if this is a problem, and if it's worth the effort to make this work when, to my knowledge, there isn't a simple solution that doesn't change the original implementation.

Closes #2693

@apa420
Copy link
Collaborator

apa420 commented May 8, 2021

I'd rather have a dropdown menu where you enable the custom badges.
Something like:
Enable custom FFZ badges for:

  • VIP and Moderator
  • VIP
  • Moderator
  • None
    Where VIP and Moderator are default.

(Before you implement it it'd be better if someone else has an opinion on this)

For example I think some of the VIP badges are stupid so I'd make sense to disable them while moderator badges you can always tell that they are moderator badges.

@auxtinn
Copy link

auxtinn commented May 8, 2021

I'd rather have a dropdown menu where you enable the custom badges.

Something like:

Enable custom FFZ badges for:

  • VIP and Moderator

  • VIP

  • Moderator

  • None

Where VIP and Moderator are default.

(Before you implement it it'd be better if someone else has an opinion on this)

For example I think some of the VIP badges are stupid so I'd make sense to disable them while moderator badges you can always tell that they are moderator badges.

i feel like the "bot" badge from ffz/bttv should be implemented too.

@apa420
Copy link
Collaborator

apa420 commented May 8, 2021

That's a separate issue.

@pajlada
Copy link
Member

pajlada commented May 15, 2021

In the long run a dropdown with a string value won't make sense so it's more worth keeping the settings as 'single values', even though it will add a bit more clutter now it can be cleaned up the future if another value were to be added. tl;dr: 2 checkboxes > 1 dropdown menu imo. Setting scope is fine, setting position we've chatted about but it can be added after a separator in the "Visible badges" category

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👌

@zneix zneix changed the title Add setting for custom ffz mod/VIP badges Add setting to disable custom ffz mod/VIP badges May 16, 2021
@zneix zneix enabled auto-merge (squash) May 16, 2021 17:13
@fourtf fourtf disabled auto-merge May 16, 2021 17:14
@zneix zneix enabled auto-merge (squash) May 16, 2021 19:31
@zneix zneix disabled auto-merge May 16, 2021 19:38
@zneix zneix merged commit 2db50f1 into Chatterino:master May 16, 2021
vaehx added a commit to vaehx/chatterino2 that referenced this pull request May 16, 2021
* chatterino/master:
  Add setting to disable custom ffz mod/VIP badges (Chatterino#2759)
  v2.3.2
  added try catch in nm (Chatterino#2785)
  Fixed deprecated method Qt::SystemLocaleLongDate (Chatterino#2784)
  Migrated cheermotes to Helix API (Chatterino#2440)
  Fix word backspacing not closing/updating colon emote picker (Chatterino#2781)
  Load 100 blocked users instead of default 20 (Chatterino#2772)
  Refactored and Migrated to Helix AutoMod message management (Chatterino#2779)
  Add flatpak version badge (Chatterino#2782)
  Bump dangoslen/changelog-enforcer from 2.1.0 to 2.2.0 (Chatterino#2770)
  Bump ilammy/msvc-dev-cmd from 1.7.0 to 1.8.0 (Chatterino#2769)
@talneoran talneoran deleted the custom-ffz-badges-setting branch May 23, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a setting to disable FFZ custom VIP/mod badges
5 participants