Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reply popup after thread update #4923

Merged
merged 21 commits into from
Nov 5, 2023

Conversation

iProdigy
Copy link
Contributor

@iProdigy iProdigy commented Oct 28, 2023

Follow-up to #4919 (review)
Closes #4762

  • right click on a message > 'View thread' now shows all relevant messages
  • right click on a message > 'Reply to message' now replies to the correct message rather than thread root
  • added Reply to original thread menu action

Copy link
Contributor

@Nerixyz Nerixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍. Just two small things I noticed.

'Reply to message' now replies to the correct message rather than thread root

It would be great if there was a menu option like 'Rep&ly to thread' which would reply to the thread root.

src/messages/Message.hpp Outdated Show resolved Hide resolved
src/providers/twitch/IrcMessageHandler.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/providers/twitch/IrcMessageHandler.cpp Outdated Show resolved Hide resolved
src/singletons/helper/LoggingChannel.cpp Outdated Show resolved Hide resolved
src/widgets/splits/SplitInput.cpp Show resolved Hide resolved
src/widgets/splits/SplitInput.cpp Show resolved Hide resolved
src/widgets/splits/SplitInput.hpp Show resolved Hide resolved
@iProdigy iProdigy marked this pull request as ready for review November 1, 2023 00:30
@pajlada pajlada enabled auto-merge (squash) November 5, 2023 15:55
@pajlada pajlada merged commit 5209e47 into Chatterino:master Nov 5, 2023
15 checks passed
@iProdigy iProdigy deleted the fix/thread-ui-update branch November 5, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants