Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: /reply command now replies to the latest message of the user #4919

Merged
merged 10 commits into from
Nov 5, 2023
Merged

feat: /reply command now replies to the latest message of the user #4919

merged 10 commits into from
Nov 5, 2023

Conversation

iProdigy
Copy link
Contributor

Keep thread continuity when using /reply command by replying directly to the message id rather than the root id.

Since Twitch updated their reply logic, this approach shows the correct parent username/body now

Screenshot_20231024_213424

Nerixyz
Nerixyz reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@Nerixyz Nerixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really an issue from this PR, but it might be confusing that messages from nested threads don't get added to the original thread:

Felanbird
Felanbird approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted by neri visually it would be nice if threads were nested, but this behavior is not any different than what Chatterino users currently experience from 7tv browser chatters, and also not for this PR.

@iProdigy iProdigy mentioned this pull request Oct 28, 2023
Merged
@pajlada pajlada changed the title Avoid thread root id when using /reply command feat: /reply command now replies to the latest message of the user Nov 5, 2023
@pajlada pajlada enabled auto-merge (squash) November 5, 2023 10:52
@pajlada pajlada disabled auto-merge November 5, 2023 12:18
@pajlada pajlada merged commit 9dd83b0 into Chatterino:master Nov 5, 2023
14 of 15 checks passed
@iProdigy iProdigy deleted the fix/command-reply-thread-parent branch November 5, 2023 15:47
@ilya-zlobintsev ilya-zlobintsev mentioned this pull request Jan 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nerixyz Nerixyz Nerixyz left review comments

@Felanbird Felanbird Felanbird approved these changes

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iProdigy @pajlada @Nerixyz @Felanbird