Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs when using py 3.6 #24

Merged
merged 4 commits into from
Feb 10, 2020
Merged

fix bugs when using py 3.6 #24

merged 4 commits into from
Feb 10, 2020

Conversation

dongchirua
Copy link
Contributor

  1. fixed places where print functions are invoked
  2. fixed include headers

Copy link
Contributor

@josepablog josepablog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing this!

  • Can you please increase the minor version in setup.py?
  • Maybe add a comment there saying that this is a Python 3.6 library

@dongchirua
Copy link
Contributor Author

@josepablog I have changed as you requested :)

@josepablog
Copy link
Contributor

Very sorry for the back and forth, but I think if we follow semantic versioning (https://semver.org) it should be 0.9.0, this is not a bug fix, and we are breaking compatibility.

@josepablog
Copy link
Contributor

thank you for the work

correct version to `0.9.0`
@dongchirua
Copy link
Contributor Author

@josepablog I changed :) please check

@josepablog josepablog merged commit 9288ffd into CheggEng:master Feb 10, 2020
@josepablog
Copy link
Contributor

thank you for your help with this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants