15/05/24 update existing company jobs #162
Conversation
|
Can you fix the run errors Dan? Looks like VCR may have got turned off somehow |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| options = { headers: { 'Accept' => 'application/json' } } | ||
|
|
||
| begin | ||
| response = HTTParty.get(api_url, options) |
Check failure
Code scanning / CodeQL
Server-side request forgery Critical
There was a problem hiding this comment.
Added sanitize url to patch this
There was a problem hiding this comment.
Need to consider how we're going to get the invalid IDs csv out of Heroku
There was a problem hiding this comment.
Are we still having standard application_field hashes or is this just for testing?
There was a problem hiding this comment.
Super nice we can get this from the API!
There was a problem hiding this comment.
How come the change to phone_number? Does that need to be reflected elsewhere?
There was a problem hiding this comment.
Need to approve Ilya's updates in his prior PR before this can go through - make sure we're not losing any functionality in the cross-over
There was a problem hiding this comment.
Apologies if this was where the job_description error was
| options = { headers: { 'Accept' => 'application/json' } } | ||
|
|
||
| begin | ||
| response = HTTParty.get(api_url, options) |
There was a problem hiding this comment.
Added sanitize url to patch this
There was a problem hiding this comment.
Added sanitize_url to fix this, although appreciate the risk is minimal
There was a problem hiding this comment.
Wrapped the API calls in cassettes - previously were building but not calling them
There was a problem hiding this comment.
How come the change in API endpoint?
Cleaned up UpdateExistingCompanyJobs so it now uses #create_all_relevant_jobs and updates both ats_identifiers.csv and invalid_ids.csv when finished. Some bugfixes along the way and a few tweaks to CheckUrlIsValid to make json queries more tolerant of redirects, timeouts and other weird server responses.