Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21/05/24 job show page #169

Merged
merged 8 commits into from
May 24, 2024
Merged

21/05/24 job show page #169

merged 8 commits into from
May 24, 2024

Conversation

daniel-sussman
Copy link
Collaborator

Merge this AFTER merging PR #162. Properly displays HTML tags on jobs#show.

@Ches-ctrl Ches-ctrl changed the base branch from master to 15/05/24_UpdateExistingCompanyJobs May 24, 2024 07:48
@Ches-ctrl Ches-ctrl changed the base branch from 15/05/24_UpdateExistingCompanyJobs to master May 24, 2024 07:53
Copy link
Owner

@Ches-ctrl Ches-ctrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can approve this as soon as Ilya's PR has been tested and other PR can go through. Will fix merge conflicts at that point

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting (new to me). We create types of errors?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this is the only change relative to the other PR

@Ches-ctrl Ches-ctrl changed the base branch from master to 15/05/24_UpdateExistingCompanyJobs May 24, 2024 10:54
@Ches-ctrl Ches-ctrl changed the base branch from 15/05/24_UpdateExistingCompanyJobs to master May 24, 2024 10:55
Copy link
Owner

@Ches-ctrl Ches-ctrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big merges for a small update lol

@Ches-ctrl Ches-ctrl merged commit 37094c3 into master May 24, 2024
7 checks passed
@Ches-ctrl Ches-ctrl deleted the 21/05/24_job_show_page branch July 1, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants