Wrong CST d.ts type generation with same label for different alternatives

[medihack]

I am generating my types for the CST visitor with generateCstDts. This works fine, but not for this rule:

  public content = this.RULE("content", () => {
    this.MANY(() => {
      this.OR([
        {
          ALT: () => {
            this.SUBRULE(this.element, { LABEL: "items" })
          },
        },
        {
          ALT: () => {
            this.SUBRULE(this.chardata, { LABEL: "items" })
          },
        },
        {
          ALT: () => {
            this.SUBRULE(this.expression, { LABEL: "items" })
          },
        },
      ])
    })
  })

I end up with a generated type like this:

export type ContentCstChildren = {
  items?: ElementCstNode[];
};

but expected something like this:

export type ContentCstChildren = {
  items?: Array<ElementCstNode | ChardataCstNode | ExpressionCstNode>

[medihack]

Ok, just took a look at the generator code and it seems to be quite tricky to make it work with LABEL correctly.

By the way, there is a little bug in the update-snapshots on line 14. It must be const result = api.generateCstDts(parser.getGAstProductions()).

[bd82]

I merged your fixed, it seems quite clean 👍