Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default @mention prefix no longer respected #39

Closed
3 tasks done
brandonfl opened this issue Dec 7, 2021 · 3 comments · Fixed by #40
Closed
3 tasks done

Default @mention prefix no longer respected #39

brandonfl opened this issue Dec 7, 2021 · 3 comments · Fixed by #40

Comments

@brandonfl
Copy link

Issue Checklist

  • I have checked for similar issues on the Issue tracker
  • I have updated to the latest version of JDA-Chewtils.
  • I have checked the branches or the maintainer's PRs for upcoming bug fixes.

Affected Modules

Command

Description

When I try to use the mention prefix, it dont work at all with Chewtils.
I've tryed doing the same on JDA-Utilities and it work

image

@brandonfl brandonfl changed the title Currently not possible to use @mention prefix for commands It's currently not possible to use @mention prefix for commands Dec 7, 2021
@Chew
Copy link
Owner

Chew commented Dec 11, 2021

What are you setting your prefix to?

https://github.com/Chewbotcca/Discord/blob/main/src/main/java/pw/chew/chewbotcca/Chewbotcca.java#L90

I'm able to get it to work with <@!clientid>

image

@brandonfl
Copy link
Author

brandonfl commented Dec 11, 2021

@Chew The prefix that i've tryed are :

  • Use default prefix (dont set any prefix)
  • Use the generic prefix @mention

In the 2 cases, it dont work.
With JDA-Utilities, if you dont set any prefix or if you set to @mention, the prefix is automatically changed with the client id of the bot.

Here is the code related to this feature into JDA-Utilities :

JDA-Applications CommandClientImpl.java line 67 :

 line 67

JDA-Applications CommandClientImpl.java lines 498 to 506 :

lines 498 to 506

There is no reason to have to manually set the prefix with the client id.
In my case, I provide bots on-premise, I dont want that people have to set prefix with client-id. The default prefix should do the job

@brandonfl
Copy link
Author

Another point of the @mention feature is for the help builder.
It should translate the @mention by the @Bot name for exemple :

D0jE6NqW6m

In your situation, it show :

DiscordCanary_AC5b4X0jdY

That's not user friendly, like, a developper can understand it if he know how the discord api work, but not a user

@Chew Chew changed the title It's currently not possible to use @mention prefix for commands Default @mention prefix no longer respected Dec 12, 2021
@Chew Chew linked a pull request Dec 20, 2021 that will close this issue
5 tasks
@Chew Chew closed this as completed in #40 Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants