Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests covering WalletService RPCs and related functions #1796

Merged
merged 4 commits into from
Jun 1, 2023

Conversation

paninaro
Copy link
Contributor

Covers most of the WalletService methods, stopping short of testing the state changed handlers.

@paninaro paninaro requested a review from zsolt-dev May 27, 2023 02:42
Copy link
Contributor

@zsolt-dev zsolt-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are testing implementation detail. Those will most likely be replaced with tests that will check the results from the simulator in the future. So for now, its a good middle ground between complexity and usefulness.

@paninaro paninaro merged commit 1abbd3c into main Jun 1, 2023
@paninaro paninaro deleted the paninaro.wallet_service_tests branch June 1, 2023 15:49
paninaro added a commit to Chia-Network/chia-blockchain that referenced this pull request Jun 5, 2023
* add tests covering WalletService RPCs and related functions by @paninaro in Chia-Network/chia-blockchain-gui#1796
* disconnect sessions when disconnecting a WC pairing by @paninaro in Chia-Network/chia-blockchain-gui#1816
* fixed switching between keys by @seeden in Chia-Network/chia-blockchain-gui#1815
* replace isURL usage with isValidURL by @paninaro in Chia-Network/chia-blockchain-gui#1813
* small bug fixes by @seeden in Chia-Network/chia-blockchain-gui#1818
* [Snyk] Security upgrade vite from 3.1.1 to 3.2.7 by @ChiaAutomation in Chia-Network/chia-blockchain-gui#1819
* Add clawback feature to the GUI by @zsolt-dev in Chia-Network/chia-blockchain-gui#1802
* Rifeljm/#1699 verifiable credentials by @rifeljm in Chia-Network/chia-blockchain-gui#1820

**Full Changelog**: Chia-Network/chia-blockchain-gui@1.8.2-rc1...1.8.2-rc2
wallentx pushed a commit to Chia-Network/chia-blockchain that referenced this pull request Jun 6, 2023
Bump chia-blockchain-gui to 60491b6c68cec864fa6169ffca77db5ca3086399

* add tests covering WalletService RPCs and related functions by @paninaro in Chia-Network/chia-blockchain-gui#1796
* disconnect sessions when disconnecting a WC pairing by @paninaro in Chia-Network/chia-blockchain-gui#1816
* fixed switching between keys by @seeden in Chia-Network/chia-blockchain-gui#1815
* replace isURL usage with isValidURL by @paninaro in Chia-Network/chia-blockchain-gui#1813
* small bug fixes by @seeden in Chia-Network/chia-blockchain-gui#1818
* [Snyk] Security upgrade vite from 3.1.1 to 3.2.7 by @ChiaAutomation in Chia-Network/chia-blockchain-gui#1819
* Add clawback feature to the GUI by @zsolt-dev in Chia-Network/chia-blockchain-gui#1802
* Rifeljm/#1699 verifiable credentials by @rifeljm in Chia-Network/chia-blockchain-gui#1820

**Full Changelog**: Chia-Network/chia-blockchain-gui@1.8.2-rc1...1.8.2-rc2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants