replace isURL usage with isValidURL #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seeden
approved these changes
Jun 2, 2023
paninaro
added a commit
to Chia-Network/chia-blockchain
that referenced
this pull request
Jun 5, 2023
* add tests covering WalletService RPCs and related functions by @paninaro in Chia-Network/chia-blockchain-gui#1796 * disconnect sessions when disconnecting a WC pairing by @paninaro in Chia-Network/chia-blockchain-gui#1816 * fixed switching between keys by @seeden in Chia-Network/chia-blockchain-gui#1815 * replace isURL usage with isValidURL by @paninaro in Chia-Network/chia-blockchain-gui#1813 * small bug fixes by @seeden in Chia-Network/chia-blockchain-gui#1818 * [Snyk] Security upgrade vite from 3.1.1 to 3.2.7 by @ChiaAutomation in Chia-Network/chia-blockchain-gui#1819 * Add clawback feature to the GUI by @zsolt-dev in Chia-Network/chia-blockchain-gui#1802 * Rifeljm/#1699 verifiable credentials by @rifeljm in Chia-Network/chia-blockchain-gui#1820 **Full Changelog**: Chia-Network/chia-blockchain-gui@1.8.2-rc1...1.8.2-rc2
wallentx
pushed a commit
to Chia-Network/chia-blockchain
that referenced
this pull request
Jun 6, 2023
Bump chia-blockchain-gui to 60491b6c68cec864fa6169ffca77db5ca3086399 * add tests covering WalletService RPCs and related functions by @paninaro in Chia-Network/chia-blockchain-gui#1796 * disconnect sessions when disconnecting a WC pairing by @paninaro in Chia-Network/chia-blockchain-gui#1816 * fixed switching between keys by @seeden in Chia-Network/chia-blockchain-gui#1815 * replace isURL usage with isValidURL by @paninaro in Chia-Network/chia-blockchain-gui#1813 * small bug fixes by @seeden in Chia-Network/chia-blockchain-gui#1818 * [Snyk] Security upgrade vite from 3.1.1 to 3.2.7 by @ChiaAutomation in Chia-Network/chia-blockchain-gui#1819 * Add clawback feature to the GUI by @zsolt-dev in Chia-Network/chia-blockchain-gui#1802 * Rifeljm/#1699 verifiable credentials by @rifeljm in Chia-Network/chia-blockchain-gui#1820 **Full Changelog**: Chia-Network/chia-blockchain-gui@1.8.2-rc1...1.8.2-rc2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some NFTs have content URLs containing unencoded spaces. While most of the code handles this without any trouble, the isURL function from the validator library will return false, causing these NFTs to fail to load.
This change introduces an
isValidURLfunction that will encode URLs if necessary and then return the result ofisURL(encodedURL).Tested with NFTs that have encoded and unencoded spaces.