test_services.py flaky test. (#16518)

chia/simulator/socket.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
-import secrets
 import socket
+from contextlib import closing
 from typing import Set
 
 recent_ports: Set[int] = set()
@@ -11,17 +11,17 @@ def find_available_listen_port(name: str = "free") -> int:
     global recent_ports
 
     while True:
-        port = secrets.randbelow(0xFFFF - 1024) + 1024
-        if port in recent_ports:
-            continue
-
-        with socket.socket() as s:
+        with closing(socket.socket(socket.AF_INET, socket.SOCK_STREAM)) as s:
             try:
-                s.bind(("127.0.0.1", port))
+                s.bind(("", 0))
+                s.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
+                port = s.getsockname()[1]
             except OSError:
-                recent_ports.add(port)
                 continue
 
+        if port in recent_ports:
+            continue
+
         recent_ports.add(port)
         print(f"{name} port: {port}")
-        return port
+        return port  # type: ignore

tests/core/services/config.py

@@ -0,0 +1,3 @@
+from __future__ import annotations
+
+parallel = False

tests/core/test_services.py → tests/core/services/test_services.py

@@ -138,7 +138,10 @@ async def test_services_terminate(
 
                     try:
                         result = await client.healthz()
-                    except aiohttp.client_exceptions.ClientConnectorError:
+                    except (
+                        aiohttp.client_exceptions.ClientConnectorError,
+                        aiohttp.client_exceptions.ClientResponseError,
+                    ):
                         pass
                     else:
                         if result.get("success", False):