Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_services.py flaky test. #16518

Merged
merged 27 commits into from
Oct 10, 2023
Merged

test_services.py flaky test. #16518

merged 27 commits into from
Oct 10, 2023

Conversation

fchirica
Copy link
Contributor

@fchirica fchirica commented Oct 3, 2023

Fixes the flakiness of test_services.py: the function find_available_listen_port would rarely give an already in use port. This PR enhances the logic of find_available_listen_port. During the stress testing, it no longer returned already in use ports. Additionally, it fixes a (theoretical) race where tests would run in parallel and find_available_listen_port would give the same port by setting parallel=False.

@fchirica fchirica added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Oct 3, 2023
@fchirica fchirica closed this Oct 4, 2023
@fchirica fchirica reopened this Oct 4, 2023
@coveralls-official
Copy link

coveralls-official bot commented Oct 6, 2023

Pull Request Test Coverage Report for Build 6431831714

  • 8 of 9 (88.89%) changed or added relevant lines in 2 files are covered.
  • 70513 unchanged lines in 571 files lost coverage.
  • Overall coverage decreased (-73.4%) to 16.162%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/simulator/socket.py 7 8 87.5%
Files with Coverage Reduction New Missed Lines %
chia/consensus/constants.py 1 92.65%
chia/consensus/pos_quality.py 1 80.0%
chia/full_node/fee_estimation.py 1 97.62%
chia/protocols/pool_protocol.py 1 98.46%
chia/server/outbound_message.py 1 95.83%
chia/types/blockchain_format/reward_chain_block.py 1 97.56%
chia/util/db_synchronous.py 1 75.0%
chia/util/permissions.py 1 88.89%
chia/wallet/uncurried_puzzle.py 1 90.0%
chia/wallet/util/notifications.py 1 87.5%
Totals Coverage Status
Change from base Build 6425197397: -73.4%
Covered Lines: 17030
Relevant Lines: 97723

💛 - Coveralls

@fchirica fchirica marked this pull request as ready for review October 6, 2023 13:51
@fchirica fchirica requested a review from a team as a code owner October 6, 2023 13:51
@fchirica fchirica requested a review from emlowe October 6, 2023 13:51
@cmmarslender cmmarslender merged commit 33edfa8 into main Oct 10, 2023
242 checks passed
@cmmarslender cmmarslender deleted the fc.test_services branch October 10, 2023 18:44
fchirica added a commit that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coverage-diff Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants