Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create tasks for stopping services #13848

Merged
merged 1 commit into from
Nov 10, 2022
Merged

create tasks for stopping services #13848

merged 1 commit into from
Nov 10, 2022

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Nov 7, 2022 •
edited
Loading

https://docs.python.org/3.11/whatsnew/changelog.html#changelog

bpo-34790: Remove passing coroutine objects to asyncio.wait().

In Python 3.11 asyncio.wait() does not automatically create tasks from
coroutines passed to it. This manually creates the tasks prior to calling
asyncio.wait().

Draft for:

(cherry picked from commit 855b5d1)

@altendky
create tasks for stopping services
a5a8407 
(cherry picked from commit 3384714f2e3e0bdc8c3d3741027e9e4fb69a6002)
(cherry picked from commit 855b5d1)
@altendky altendky mentioned this pull request Nov 7, 2022
Merged
27 tasks
@altendky altendky marked this pull request as ready for review November 8, 2022 02:14
@altendky altendky requested a review from a team as a code owner November 8, 2022 02:14
@altendky altendky closed this Nov 10, 2022
@altendky altendky reopened this Nov 10, 2022
jack60612
jack60612 approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@jack60612 jack60612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry i meant to approve earlier, lgtm

@altendky altendky removed the request for review from xdustinface November 10, 2022 14:39
@wallentx wallentx merged commit 09f89c0 into main Nov 10, 2022
@wallentx wallentx deleted the create_tasks_for_service_stopping branch November 10, 2022 20:03
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack60612 jack60612 jack60612 approved these changes

@emlowe emlowe emlowe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@altendky @jack60612 @emlowe @wallentx