Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: Fix versions for incoming connections #15465

Merged
merged 1 commit into from
Jun 7, 2023
Merged

server: Fix versions for incoming connections #15465

merged 1 commit into from
Jun 7, 2023

Conversation

xdustinface
Copy link
Contributor

@xdustinface xdustinface commented Jun 7, 2023 •
edited
Loading

Purpose:

Store protocol_version and software_version reported in the handshake of incoming connections.

Current Behavior:

Incoming connections have a 0 version for protocol_version and version.

New Behavior:

We store the actual versions reported by the handshake.

Testing Notes:

Adjusted the related test.

@xdustinface xdustinface added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jun 7, 2023
@xdustinface xdustinface requested a review from a team as a code owner June 7, 2023 14:58
arvidn
arvidn approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have expected the crawler to use this class too. It manages to record the correct version, afaik.

@xdustinface
Copy link
Contributor Author

It manages to record the correct version, afaik.

For outgoing connections, i guess?

@hoffmang9
Copy link
Member

Crawler is a false node and only connects outbound.

@wallentx wallentx merged commit d23ea4d into Chia-Network:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

Assignees
No one assigned
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xdustinface @hoffmang9 @arvidn @wallentx