Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename USDS --> USDSC #16295

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Rename USDS --> USDSC #16295

merged 1 commit into from
Sep 11, 2023

Conversation

paninaro
Copy link
Contributor

@paninaro paninaro commented Sep 8, 2023

Purpose:

Rename USDS to USDSC for CAT asset ID 6d95dae356e32a71db5ddcb42224754a02524c615c5fc35f568c2af04774e589

Note that this will not rename existing USDS wallets that have been added to the wallet DB.

@paninaro paninaro requested a review from a team as a code owner September 8, 2023 22:17
@paninaro paninaro added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Sep 8, 2023
Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paninaro paninaro added the ready_to_merge Submitter and reviewers think this is ready label Sep 8, 2023
@arvidn
Copy link
Contributor

arvidn commented Sep 9, 2023

is the asset ID for the new USDS not known yet? I suppose the new asset ID needs a different name either way, to not collide with USDS assets in wallets that haven't renamed them

@cmmarslender cmmarslender merged commit b4dd2a4 into main Sep 11, 2023
206 of 207 checks passed
@cmmarslender cmmarslender deleted the paninaro.usdsc branch September 11, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants