fix issue with syncing testnet, introduced in: Get block spends (#16451) #16618
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
When soft fork 2 activated on mainnet, most of the pre-softfork special cases were removed from the code. However, testnet still violated some of the new soft-fork rules prior to activation, so some soft fork 2 special cases need to remain in order to support testnet.
Specifically, the
NO_RELATIVE_CONDITIONS_ON_EPHEMERAL
need to be disabled on lower block heights. On mainnet, this is always active now.There was a bug in #16451 which enabled
NO_RELATIVE_CONDITIONS_ON_EPHEMERAL
unconditionally, which is fine on mainnet, but not on testnet. This restores the previous behavior.Current Behavior:
testnet10 can not sync from scratch
New Behavior:
testnet10 can sync from scratch (although, I have not tested this)
Testing Notes:
I'm hoping @cmmarslender can test the sync-from-scratch on testnet10.