Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with syncing testnet, introduced in: Get block spends (#16451) #16618

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Oct 13, 2023

Purpose:

When soft fork 2 activated on mainnet, most of the pre-softfork special cases were removed from the code. However, testnet still violated some of the new soft-fork rules prior to activation, so some soft fork 2 special cases need to remain in order to support testnet.

Specifically, the NO_RELATIVE_CONDITIONS_ON_EPHEMERAL need to be disabled on lower block heights. On mainnet, this is always active now.

There was a bug in #16451 which enabled NO_RELATIVE_CONDITIONS_ON_EPHEMERAL unconditionally, which is fine on mainnet, but not on testnet. This restores the previous behavior.

Current Behavior:

testnet10 can not sync from scratch

New Behavior:

testnet10 can sync from scratch (although, I have not tested this)

Testing Notes:

I'm hoping @cmmarslender can test the sync-from-scratch on testnet10.

@arvidn arvidn requested a review from a team as a code owner October 13, 2023 13:31
@arvidn arvidn added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Oct 13, 2023
@arvidn
Copy link
Contributor Author

arvidn commented Oct 14, 2023

The sync test appears to have succeeded

@arvidn arvidn requested a review from wjblanke October 14, 2023 14:37
@coveralls-official
Copy link

Pull Request Test Coverage Report for Build 6508907290

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 18 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.01%) to 89.715%

Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node_api.py 1 78.23%
chia/server/node_discovery.py 1 78.57%
chia/full_node/full_node.py 2 86.01%
chia/timelord/timelord_launcher.py 3 61.17%
chia/wallet/wallet_node.py 5 87.49%
chia/daemon/server.py 6 86.79%
Totals Coverage Status
Change from base Build 6485614031: -0.01%
Covered Lines: 87060
Relevant Lines: 97024

💛 - Coveralls

Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@cmmarslender cmmarslender merged commit c21c2d6 into release/2.1.2 Oct 16, 2023
549 of 550 checks passed
@cmmarslender cmmarslender deleted the fix-testnet-sync branch October 16, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants