generalize JSON serializer #16733
Merged
generalize JSON serializer #16733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_dict(), not just dataclasses
arvidn
added
the
Fixed
altendky
approved these changes
Oct 30, 2023
emlowe
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
This makes it work with any type that has a
to_json_dict()member, not just dataclasses.Not making this change was an oversight when introducing the first rust native types among our protocol message types. (here: #11503 ). That PR updates
recurse_jsonify()(here: https://github.com/Chia-Network/chia-blockchain/pull/11503/files#diff-dd6f0c93f94df70ed7b9693a16d72d4d79e9f2338eb65b13bebad03b28d9593cR145-R147 ).This highlights that we currently have two functions to convert a structure to json,
recurse_jsonify()as well as theEnhancedJSONEncoder. That seems a bit risky.