Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clvm mypie #16898

Merged
merged 47 commits into from
May 22, 2024
Merged

clvm mypie #16898

merged 47 commits into from
May 22, 2024

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Nov 21, 2023 •
edited
Loading

Purpose:

Chia-Network/clvm#125

Current Behavior:

New Behavior:

Testing Notes:

Draft For:

  • pin to a released clvm
  • figure out test failures
  • review TODO: reviews

@altendky altendky added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Nov 21, 2023
@altendky altendky mentioned this pull request Nov 21, 2023
Closed
@altendky altendky self-assigned this Nov 27, 2023
@altendky altendky closed this Dec 19, 2023
@altendky altendky reopened this Dec 19, 2023
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Dec 19, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 8384737933

Details

  • 195 of 204 (95.59%) changed or added relevant lines in 42 files are covered.
  • 14 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.02%) to 90.847%
Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/types/blockchain_format/program.py 17 18 94.44%
chia/wallet/wallet_singleton_store.py 2 3 66.67%
chia/wallet/nft_wallet/nft_puzzles.py 19 21 90.48%
chia/wallet/nft_wallet/transfer_program_puzzle.py 0 2 0.0%
chia/_tests/wallet/test_singleton_lifecycle_fast.py 11 14 78.57%
Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.52%
chia/wallet/did_wallet/did_wallet_puzzles.py 1 86.08%
chia/full_node/full_node_api.py 1 79.32%
chia/rpc/rpc_server.py 1 89.0%
chia/_tests/wallet/test_singleton_lifecycle_fast.py 1 95.23%
chia/_tests/core/util/test_lockfile.py 1 91.09%
chia/server/node_discovery.py 1 79.79%
chia/full_node/full_node.py 1 85.12%
chia/wallet/wallet_node.py 2 88.56%
chia/server/server.py 4 80.0%
Totals Coverage Status
Change from base Build 8378992295: 0.02%
Covered Lines: 97473
Relevant Lines: 107270
💛 - Coveralls

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Dec 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Dec 22, 2023
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Dec 24, 2023
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Dec 27, 2023
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Dec 27, 2023
@altendky altendky marked this pull request as ready for review May 7, 2024 22:36
@altendky altendky requested a review from a team as a code owner May 7, 2024 22:36
@altendky altendky requested a review from Quexington May 7, 2024 22:36
Quexington
Quexington previously approved these changes May 8, 2024
View reviewed changes
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label May 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label May 13, 2024
@altendky altendky requested a review from emlowe May 13, 2024 16:58
Quexington
Quexington previously approved these changes May 13, 2024
View reviewed changes
@altendky altendky closed this May 21, 2024
@altendky altendky reopened this May 21, 2024
emlowe
emlowe previously approved these changes May 21, 2024
View reviewed changes
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label May 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@altendky altendky dismissed stale reviews from emlowe and Quexington via f3827cd May 21, 2024 19:03
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label May 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@altendky altendky closed this May 22, 2024
@altendky altendky reopened this May 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

File Coverage Missing Lines
chia/_tests/wallet/test_singleton_lifecycle_fast.py 78.6% lines 115, 315, 389
chia/types/blockchain_format/program.py 94.4% lines 223
chia/wallet/nft_wallet/nft_puzzles.py 90.5% lines 239, 263
chia/wallet/nft_wallet/transfer_program_puzzle.py 0.0% lines 42, 82
Total Missing Coverage
176 lines 8 lines 95%

@cmmarslender cmmarslender merged commit a58cc33 into main May 22, 2024
698 of 704 checks passed
@cmmarslender cmmarslender deleted the clvm_mypie branch May 22, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlowe emlowe emlowe approved these changes

@Quexington Quexington Quexington left review comments

Assignees

@altendky altendky

Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog coverage-diff Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@altendky @Quexington @emlowe @cmmarslender @AmineKhaldi