Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHIA-619 Annotate test_trades.py #17447

Merged
merged 1 commit into from
Jun 11, 2024
Merged

CHIA-619 Annotate test_trades.py #17447

merged 1 commit into from
Jun 11, 2024

Conversation

AmineKhaldi
Copy link
Contributor

No description provided.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Jan 31, 2024
@AmineKhaldi AmineKhaldi self-assigned this Jan 31, 2024
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Jan 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9193764190

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 39 of 39 (100.0%) changed or added relevant lines in 1 file are covered.
  • 86 unchanged lines in 26 files lost coverage.
  • Overall coverage decreased (-0.07%) to 90.828%
Files with Coverage Reduction New Missed Lines %
chia/data_layer/download_data.py 1 83.58%
chia/daemon/keychain_proxy.py 1 72.57%
chia/_tests/util/test_priority_mutex.py 1 99.66%
chia/farmer/farmer.py 1 72.23%
chia/wallet/util/wallet_sync_utils.py 1 86.54%
chia/timelord/timelord_launcher.py 1 70.07%
chia/_tests/util/full_sync.py 1 88.95%
chia/rpc/wallet_rpc_api.py 1 89.37%
chia/introducer/introducer.py 1 78.26%
chia/util/json_util.py 1 88.46%
Totals Coverage Status
Change from base Build 9191865873: -0.07%
Covered Lines: 99227
Relevant Lines: 109189
💛 - Coveralls

@AmineKhaldi AmineKhaldi marked this pull request as ready for review January 31, 2024 19:14
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner January 31, 2024 19:14
arvidn
arvidn reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this patch is almost entirely formatting changes. I don't think it's a good idea to mix formatting changes and functional changes. It's also not obvious (to me) that these formatting changes are for the better.

tests/wallet/cat_wallet/test_trades.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added merge_conflict Branch has conflicts that prevent merge to main labels Jan 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jan 31, 2024
Quexington
Quexington previously approved these changes Jan 31, 2024
View reviewed changes
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Feb 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label May 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@AmineKhaldi AmineKhaldi reopened this May 22, 2024
@AmineKhaldi AmineKhaldi changed the title Annotate test_trades.py CHIA-619 Annotate test_trades.py May 28, 2024
@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Jun 11, 2024
@cmmarslender cmmarslender merged commit 387619b into Chia-Network:main Jun 11, 2024
703 of 705 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

@Quexington Quexington Quexington left review comments

Assignees

@AmineKhaldi AmineKhaldi

Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AmineKhaldi @arvidn @Quexington @cmmarslender