Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSocrata hangs when passing along SoDA queries with small number of results #14

Closed
tomschenkjr opened this issue Jan 3, 2015 · 3 comments
Assignees
Labels
Milestone

Comments

@tomschenkjr
Copy link
Contributor

tomschenkjr commented Jan 3, 2015

When passing queries that yield few results seems to cause RSocrata to hang. While there were a few permutations, the examples below demonstrate the issue while each one was successful through hurl.it.

read.socrata("https://data.cityofchicago.org/resource/xzkq-xp2w.json?$limit=500") # Success
read.socrata("https://data.cityofchicago.org/resource/xzkq-xp2w.json?$limit=250") # Success
read.socrata("https://data.cityofchicago.org/resource/xzkq-xp2w.json?$limit=100") # Success
read.socrata("https://data.cityofchicago.org/resource/xzkq-xp2w.json?$limit=50") # Success
read.socrata("https://data.cityofchicago.org/resource/xzkq-xp2w.json?$limit=25") # Hangs
read.socrata("https://data.cityofchicago.org/resource/xzkq-xp2w.json?$limit=10") # Hangs
read.socrata("https://data.cityofchicago.org/resource/xzkq-xp2w.json?$limit=5") # Hangs
read.socrata("https://data.cityofchicago.org/resource/xzkq-xp2w.json?$limit=1") # Hangs

Stepping through the functions, the problem seems to arise when nrow(page) is small. Have not fully diagnosed the issue, yet.

@tomschenkjr tomschenkjr added the bug label Jan 3, 2015
@tomschenkjr tomschenkjr self-assigned this Jan 3, 2015
@SEV2014 SEV2014 modified the milestone: sprint7 Mar 17, 2015
@tomschenkjr tomschenkjr modified the milestones: sprint7, v1.7.1 Oct 4, 2016
@tomschenkjr
Copy link
Contributor Author

@nicklucius - if I recall, you mentioned that the limit argument was being used improperly in RSocrata, so $limit=1 would only iterate a download at one record at a time. Correct?

If so, was that fixed?

@nicklucius
Copy link
Contributor

@tomschenkjr - yes that's correct, for cross-reference it's #83. Tomorrow I'll have a pull request ready for the fix.

@tomschenkjr
Copy link
Contributor Author

tomschenkjr commented Oct 26, 2016

👍

_
Tom Schenk Jr.
Chief Data Officer
Department of Innovation and Technology
City of Chicago
tom.schenk@cityofchicago.org | @ChicagoCDO
data.cityofchicago.org | opengrid.io | digital.cityofchicago.org | chicago.github.io | dev.cityofchicago.org

On Tue, Oct 25, 2016 at 7:25 PM -0500, "Nick Lucius" <notifications@github.commailto:notifications@github.com> wrote:

@tomschenkjrhttps://github.com/tomschenkjr - yes that's correct, for cross-reference it's #83#83. Tomorrow I'll have a pull request ready for the fix.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/14#issuecomment-256217045, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABkC0d6nPThVqiJKTeJzx48RHmiBZxmMks5q3p4JgaJpZM4DN7Qo.


This e-mail, and any attachments thereto, is intended only for use by the addressee(s) named herein and may contain legally privileged and/or confidential information. If you are not the intended recipient of this e-mail (or the person responsible for delivering this document to the intended recipient), you are hereby notified that any dissemination, distribution, printing or copying of this e-mail, and any attachment thereto, is strictly prohibited. If you have received this e-mail in error, please respond to the individual sending the message, and permanently delete the original and any copy of any e-mail and printout thereof.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants