Move to testthat

[dmpe]

6 tests will still continue to fail (bigger changes to the code required)
update description
#48

Given that users do not care about tests, I wouldn't have a problem in releasing such an update. Indeed, in order to pass all the tests, there are bigger changes required e.g. this message is a problem to testthat (not 100% sure how to fix yet)

read.socrata("https://soda.demo.socrata.com/api/views/433-bgaj") does not match '3 characters before dash instead of 4'. Actual value: "Error in validateUrl(url, app_token) : \n  433-bgaj is not a valid Socrata dataset unique identifier.\n"

Similar to the message below:

2015-07-08 19:55:02.200 getResponse: Error in httr GET: 401  http://data.cityofchicago.org/resource/j8vp-2qpg.json

[tomschenkjr]

It's so great to finally see code coverage results. I can work on the 6 tests that failed. I like to keep the integrity of the unit tests, but think it can be sorted before the push this weekend.

Below is a quick list (mostly for myself) to follow-up on after my very cursory overview:

• Investigate error on Travis CI build. It failed at an unexpected spot.
• Fix the unit tests that are unexpectedly failing. See output in Appveyor.
• Quick update to the coveralls badge to flat/square and inline with other badges.

[dmpe]

Good. You may also try to restart the build (upper right corner https://travis-ci.org/Chicago/RSocrata/builds/70104458)

[tomschenkjr]

@dmpe good point, rerun fixed the Travis hiccup. Thanks.

[tomschenkjr]

I see the issue, just some differences in the RUnit approach vesus testthat. For instance, this test passes with the syntax:

test_that("is 4x4 URL", {
  expect_error(read.socrata("https://soda.demo.socrata.com/api/views/4334c-bgajc"), "4334c-bgajc is not a valid Socrata dataset unique identifier", label="11 characters instead of 9")
  expect_error(read.socrata("https://soda.demo.socrata.com/api/views/433-bga"), "433-bga is not a valid Socrata dataset unique identifier", label="7 characters instead of 9")
  expect_error(read.socrata("https://soda.demo.socrata.com/api/views/433-bgaj"), "433-bgaj is not a valid Socrata dataset unique identifier", label="3 characters before dash instead of 4")
  expect_error(read.socrata("https://soda.demo.socrata.com/api/views/4334-!gaj"), "4334-!gaj is not a valid Socrata dataset unique identifier", label="non-alphanumeric character")
})

I will make changes to the tests that fail.