Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed test for empty json in getContentAsDataFrame() #97

Merged
merged 11 commits into from
Sep 8, 2016
Merged

Conversation

geneorama
Copy link
Member

oops, forgot that we use "issue" instead of "iss" for the branch names.

Anyway, pretty straightforward fix. I think the problem might have been introduced by Socrata, or might have been introduced by a change in httr, or maybe Kevin just found something new!

@coveralls
Copy link

coveralls commented Sep 1, 2016

Coverage Status

Coverage decreased (-1.05%) to 96.899% when pulling b894fb4 on iss96 into fa923de on master.

@geneorama
Copy link
Member Author

added test for the example url

@coveralls
Copy link

coveralls commented Sep 1, 2016

Coverage Status

Coverage decreased (-1.05%) to 96.899% when pulling 595ea09 on iss96 into fa923de on master.

@coveralls
Copy link

coveralls commented Sep 1, 2016

Coverage Status

Coverage decreased (-1.05%) to 96.899% when pulling 98be365 on iss96 into fa923de on master.

@@ -10,7 +10,7 @@ Description: Provides easier interaction with
format and manages throttling by 'Socrata'.
Users can upload data to Socrata portals directly
from R.
Version: 1.7.1-12
Version: 1.7.1-13
Date: 2016-03-13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update Date as well?

@tomschenkjr
Copy link
Contributor

@geneorama - I'm reruning the CI builds, but looks like it's just a conflict on the uploading process.

I made a couple of small comments in the code. Can you take a look at those and then also update this pull request to dev branch? I'll also merge #94 into dev for a test before pushing to master.

@geneorama
Copy link
Member Author

I didn't mean to include thelibrary(RSocrata), obviously had that in there while testing elsewhere. Updated the date.
Thanks for catching.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.05%) to 96.899% when pulling d8baa93 on iss96 into fa923de on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.05%) to 96.899% when pulling d8baa93 on iss96 into fa923de on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.05%) to 96.899% when pulling d8baa93 on iss96 into fa923de on master.

@tomschenkjr
Copy link
Contributor

@geneorama - one more fix: can you adjust the target branch to dev?

@geneorama geneorama changed the base branch from master to dev September 8, 2016 16:56
@geneorama
Copy link
Member Author

@tomschenkjr Yes, meant to use dev in the first place.

@tomschenkjr tomschenkjr merged commit c299b5c into dev Sep 8, 2016
@tomschenkjr
Copy link
Contributor

@geneorama - Oh, and duh, I forgot that I could have done it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants