-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed test for empty json in getContentAsDataFrame() #97
Conversation
added test for the example url |
@@ -10,7 +10,7 @@ Description: Provides easier interaction with | |||
format and manages throttling by 'Socrata'. | |||
Users can upload data to Socrata portals directly | |||
from R. | |||
Version: 1.7.1-12 | |||
Version: 1.7.1-13 | |||
Date: 2016-03-13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update Date
as well?
@geneorama - I'm reruning the CI builds, but looks like it's just a conflict on the uploading process. I made a couple of small comments in the code. Can you take a look at those and then also update this pull request to |
I didn't mean to include the |
2 similar comments
@geneorama - one more fix: can you adjust the target branch to |
@tomschenkjr Yes, meant to use |
@geneorama - Oh, and duh, I forgot that I could have done it |
oops, forgot that we use "issue" instead of "iss" for the branch names.
Anyway, pretty straightforward fix. I think the problem might have been introduced by Socrata, or might have been introduced by a change in
httr
, or maybe Kevin just found something new!