Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heat Map is removed when map is moved #247

Open
PriyaDoIT opened this issue Sep 23, 2016 · 5 comments
Open

Heat Map is removed when map is moved #247

PriyaDoIT opened this issue Sep 23, 2016 · 5 comments
Assignees

Comments

@PriyaDoIT
Copy link

PriyaDoIT commented Sep 23, 2016

This issue was found during regression testing for v1.3.0:

Now that we are taking strides to implement a more dynamic map (i.e., the map refreshes data when moved), we found that if a Heat Map or Layer is applied and the user then moves the map, the heat map and the layer is removed. This needs to be fixed. @rladines

We will also need a test case for this. @reve0716

@PriyaDoIT
Copy link
Author

PriyaDoIT commented Nov 1, 2016

a couple of issues while testing:

  1. it looks like the heat map is appearing under the dots. Below screenshots are an example when i select Crimes from 1/1/16 to present
    image
    image
  2. Update from @rladines on 10/28:
    "This version also still has the known issue of the heat map and tiled map not re-rendering when the map moves (and when they happen to be there before the map was moved). I’ve looked at a few options this week on how to do this cleanly and they did not work out due to side-effects. Yesterday, I did a step-back to look at another option and that’s still in progress. I think it would be good to have a discussion on whether the heat map and tile map use cases are really applicable when map extent is active as I have some questions on their usefulness."

[Priya] I do find it annoying from a user experience perspective that the heat and tile maps disappear when moving around the map.

Also, if I zoom in to a particular area>run a query> select a heat or tile map> zoom out to a larger map extent. I'd want the heat or tile maps to still remain as the query is refreshed.

With that being said, per our discussion-- I am not sure how often these two features are used and if this is worth exploring further. If the use case is at a minimum and if it is easy to only apply the heat and tile maps when not using map extent, I'd be ok with it.

@tomschenkjr and @reve0716 could you share your opinion and let us know how it should be prioritized? Thanks!

@PriyaDoIT
Copy link
Author

Hi all, per our discussion we will need to update the tile maps as the user moves around the map as Tom provided a use case for rodent baiting. I removed my comment regarding the shading taking into the city when zooming in, because I found that wasn't true (sorry!).

Also, let's not forget about the heat map appearing under the dots when it should be over (see screenshots above).

@tomschenkjr
Copy link
Contributor

To clarify this conversation: the downside of this bug is far less than the benefits of the refreshing queries. So, let's proceed with shipping v1.3.0 and keep this issue open to be resolved in the future.

@PriyaDoIT - we probably should open a different issue for the map appearing under the dots.

@tomschenkjr
Copy link
Contributor

To clarify today's conversation. This downside of this bug seems to be far less compared to the benefits of the continually updating query. So, we should proceed with v1.3.0 and keep this issue open to be resolved later.

@PriyaDoIT - we probably should create a new issue for the heat map appearing under the dots.

@PriyaDoIT
Copy link
Author

PriyaDoIT commented Nov 9, 2016

#266 is opened to address heat map appearing below dots.

moving this issue to backlog

@PriyaDoIT PriyaDoIT modified the milestones: v1.4.0, v1.3.0 Nov 9, 2016
@PriyaDoIT PriyaDoIT removed this from the v1.4.0 milestone Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants