Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for #250 & #293 #302

Merged
merged 12 commits into from Nov 9, 2017
Merged

Fixes for #250 & #293 #302

merged 12 commits into from Nov 9, 2017

Conversation

nfspeedypur
Copy link
Contributor

No description provided.

@rladines
Copy link
Collaborator

@nfspeedypur I saw an open issue #293. Is this PR for issue #250 as well? I noticed #250 has already been closed (by @reve0716 last year). Pls. clarify. thanks

@nfspeedypur
Copy link
Contributor Author

Rod, That was closed as part of the Opengrid.io release. But it was never merged into OpenGrid. I do not have to merge that change in, but I thought since I was making this change I might as well square up all of the changes.

Copy link
Collaborator

@rladines rladines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nfspeedypur Looks like the original issue as described in #293 has been resolved. However, I see another instance where a similar thing happens with datasets where there are long columns names. The long column names would cause the date operator dropdown to wrap to the next line. Here's a sample screenshot.

image

@nfspeedypur
Copy link
Contributor Author

Well I was hoping the simple change would be enough. I will look into a more complex solution where the spacing does not matter.

@rladines rladines assigned nfspeedypur and unassigned rladines Jun 22, 2017
@rladines rladines merged commit d20cc8d into Chicago:dev Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants