Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resubmit revisions to editor #88

Closed
7 tasks done
tomschenkjr opened this issue Sep 5, 2018 · 10 comments · Fixed by #91
Closed
7 tasks done

Resubmit revisions to editor #88

tomschenkjr opened this issue Sep 5, 2018 · 10 comments · Fixed by #91
Assignees
Labels
journal submission Pertains to the journal submission process
Projects
Milestone

Comments

@tomschenkjr
Copy link
Contributor

tomschenkjr commented Sep 5, 2018

As we wrap-up revisions, beginning a list of a final checklist of items. Discuss remaining items in this thread. We can assign specific responsibilities as we go along.

@tomschenkjr tomschenkjr added the journal submission Pertains to the journal submission process label Sep 5, 2018
@tomschenkjr tomschenkjr added this to the Revision 1 milestone Sep 5, 2018
@tomschenkjr tomschenkjr self-assigned this Sep 5, 2018
@tomschenkjr tomschenkjr added this to To do in Revision 1 via automation Sep 5, 2018
nicklucius added a commit that referenced this issue Sep 6, 2018
Moving code to master branch #88
@nicklucius
Copy link
Contributor

I merged the PR and am able to generate the paper on the master branch. I'll double check open issues and close them as I confirm they were addressed.

@tomschenkjr
Copy link
Contributor Author

@nicklucius - I've accepted #90 into dev and also opened a pull request against master (#91). Please confirm you want this on master.

Separately, I compared the tables using master branch from this repo and also the Clear-Water repo. Numbers are correctly generated.

I have not identified any other changes besides #91.

Revision 1 automation moved this from To do to Done Sep 10, 2018
@tomschenkjr tomschenkjr reopened this Sep 10, 2018
Revision 1 automation moved this from Done to In progress Sep 10, 2018
Revision 1 automation moved this from In progress to Done Sep 10, 2018
@nicklucius
Copy link
Contributor

Reopening. It was inadvertantly autoclosed by #91.

@nicklucius nicklucius reopened this Sep 10, 2018
Revision 1 automation moved this from Done to In progress Sep 10, 2018
@tomschenkjr
Copy link
Contributor Author

@nicklucius - can you create a new release and attach the title page and main PDF to that release? If you look at prior releases, it had two PDFs:

  • The title page only contains the title page (with author names) but no other pages
  • The manuscript eliminates the title page, but all other pages are kept.

@nicklucius
Copy link
Contributor

@tomschenkjr - the release is done, now I just need to edit the letter and submit! I'll let you know once I add the letter language so you can check it out.

@nicklucius
Copy link
Contributor

@tomschenkjr - In the resubmission process, I've noticed that the journal offers a feature to link to our data:

"In this section, you can make your research data available with your article. Sharing research data helps other researchers evaluate your findings, and increases trust in your article. Research data can include, (but is not limited to): raw data, processed data, software, algorithms, protocols, methods and materials. Please cite your research data within your article; consult your journal's Guide for Authors for instructions.
If your research data is already hosted in a repository, you can link it to your article here."

Also:
https://www.elsevier.com/authors/author-services/research-data/data-base-linking

I could link both repositories, but each one needs a DOI. Plus, I noticed the clear-water DOI links to an old commit. I am wondering if we should add a DOI for this repo and also do a new release and update the DOI for the Clear Water repo. Thoughts?

@tomschenkjr
Copy link
Contributor Author

Good idea. Probably makes most sense to link to Clear Water. Fortunately, to update the DOI for the Clear Water repository, just create a new release and a new DOI will be created.

@tomschenkjr
Copy link
Contributor Author

Here is the DOI for the paper repository (separate from the bioRxiv and Clear Water repo): https://doi.org/10.5281/zenodo.1434260

Badge: DOI

@nicklucius
Copy link
Contributor

@tomschenkjr - excellent, thank you. I hope to have it submitted today.

@nicklucius
Copy link
Contributor

@tomschenkjr - I'll give you the satisfaction of hitting close on this issue, since I got to click the submit button in Elsevier.

Revision 1 automation moved this from In progress to Done Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
journal submission Pertains to the journal submission process
Projects
No open projects
Revision 1
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants