Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mutation error dependency registration. #6674

Merged
merged 6 commits into from Dec 14, 2023

Conversation

PascalSenn
Copy link
Member

@PascalSenn PascalSenn commented Nov 5, 2023

  • ErrorNotAnnotated should also implement the same interface even though it's not annoated as an error
  • ErrorAnnotatedAndNot runs into a type collison because of the error object
    image

Copy link

github-actions bot commented Nov 5, 2023

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@michaelstaib michaelstaib marked this pull request as ready for review December 13, 2023 09:37
Copy link

github-actions bot commented Dec 13, 2023

Qodana for .NET

158 new problems were found

Inspection name Severity Problems
Use preferred style for trailing comma before new line in multiline lists 🔴 Failure 111
Unused parameter (private accessibility) 🔶 Warning 23
Type member is never used (private accessibility) 🔶 Warning 20
Redundant using directive 🔶 Warning 3
Redundant nullable warning suppression expression 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@michaelstaib michaelstaib changed the title Adjusted example for mutation conventions Fixed mutation error dependency registration. Dec 14, 2023
@michaelstaib michaelstaib merged commit c20aec1 into main Dec 14, 2023
3 checks passed
@michaelstaib michaelstaib deleted the pse/adjust-example-for-mutation-conventions branch December 14, 2023 11:41
Copy link

sonarcloud bot commented Dec 14, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

michaelstaib added a commit that referenced this pull request Dec 14, 2023
Co-authored-by: Michael Staib <michael@chillicream.com>
renovate bot added a commit to orso-co/Orso.Arpa.Api that referenced this pull request Dec 22, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [HotChocolate.Abstractions](https://chillicream.com/)
([source](https://togithub.com/ChilliCream/graphql-platform)) | `13.7.0`
-> `13.8.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/HotChocolate.Abstractions/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/HotChocolate.Abstractions/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/HotChocolate.Abstractions/13.7.0/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/HotChocolate.Abstractions/13.7.0/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [HotChocolate.AspNetCore](https://chillicream.com/)
([source](https://togithub.com/ChilliCream/graphql-platform)) | `13.7.0`
-> `13.8.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/HotChocolate.AspNetCore/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/HotChocolate.AspNetCore/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/HotChocolate.AspNetCore/13.7.0/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/HotChocolate.AspNetCore/13.7.0/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [HotChocolate.AspNetCore.Authorization](https://chillicream.com/)
([source](https://togithub.com/ChilliCream/graphql-platform)) | `13.7.0`
-> `13.8.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/HotChocolate.AspNetCore.Authorization/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/HotChocolate.AspNetCore.Authorization/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/HotChocolate.AspNetCore.Authorization/13.7.0/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/HotChocolate.AspNetCore.Authorization/13.7.0/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [HotChocolate.Data](https://chillicream.com/)
([source](https://togithub.com/ChilliCream/graphql-platform)) | `13.7.0`
-> `13.8.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/HotChocolate.Data/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/HotChocolate.Data/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/HotChocolate.Data/13.7.0/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/HotChocolate.Data/13.7.0/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [HotChocolate.Data.EntityFramework](https://chillicream.com/)
([source](https://togithub.com/ChilliCream/graphql-platform)) | `13.7.0`
-> `13.8.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/HotChocolate.Data.EntityFramework/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/HotChocolate.Data.EntityFramework/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/HotChocolate.Data.EntityFramework/13.7.0/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/HotChocolate.Data.EntityFramework/13.7.0/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [HotChocolate.Types](https://chillicream.com/)
([source](https://togithub.com/ChilliCream/graphql-platform)) | `13.7.0`
-> `13.8.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/HotChocolate.Types/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/HotChocolate.Types/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/HotChocolate.Types/13.7.0/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/HotChocolate.Types/13.7.0/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>ChilliCream/graphql-platform
(HotChocolate.Abstractions)</summary>

###
[`v13.8.0`](https://togithub.com/ChilliCream/graphql-platform/releases/tag/13.8.0)

[Compare
Source](https://togithub.com/ChilliCream/graphql-platform/compare/13.7.0...13.8.0)

##### What's Changed

- Fixed issue with the fusion configuration rewriter.
([ChilliCream/graphql-platform#6670)
- Adds example for failing error interface
([ChilliCream/graphql-platform#6665)
- Set limit on serialized message size in Subscriptions.Postgres
([ChilliCream/graphql-platform#6678)
-   Fix JsonElement serialization for StrawberryShake
- Reworked JSON scalar usage with StrawberryShake.
([ChilliCream/graphql-platform#6683)
- Updated BananaCakePop Default Version
([ChilliCream/graphql-platform#6687)
- Make postgres subscription provider compatible with npgsql 8
([ChilliCream/graphql-platform#6686)
- Handle JsonElement JsonValueKind.Null when deserializing
([ChilliCream/graphql-platform#6481)
- Fixed Utf8JsonWriterHelper to not ignore null dictionary values
([ChilliCream/graphql-platform#6689)
- Fixed the ghost files in Rider when using strawberyy shake
([ChilliCream/graphql-platform#6693)
- Fixed dotnet version check filter non version output for Strawberry
Shake
([ChilliCream/graphql-platform#6699)
- Fixed argument naming conventions for mutation conventions.
([ChilliCream/graphql-platform#6705)
- Fixed cache pollution for in/nin filter expressions
([ChilliCream/graphql-platform#6711)
- Fixed large json read corruption
([ChilliCream/graphql-platform#6713)
- Fixed typo in Banana Cake Pop docs
([ChilliCream/graphql-platform#6715)
- Update open api schema snapshot to fix unit tests
([ChilliCream/graphql-platform#6708)
- Fixed array writer reset
([ChilliCream/graphql-platform#6719)
- \[maintenance] Empty type termination using semicolon.
[ChilliCream/graphql-platform#6725)
- Added apollo federation docs
([ChilliCream/graphql-platform#5791)
- Fixed example in docs
([ChilliCream/graphql-platform#6733)
- StrawberryShake documentation fixes
([ChilliCream/graphql-platform#6742)
- Adds more documentation for BCP
([ChilliCream/graphql-platform#6709)
- Avoid writing BOM in StrawberryShake Tools
([ChilliCream/graphql-platform#6751)
- Fixed transport layer byte-array handling.
([ChilliCream/graphql-platform#6763)
- Fixed SSE message corruption
([ChilliCream/graphql-platform#6642)
- Do not send omitted arguments with default values to subgraph
([ChilliCream/graphql-platform#6767)
- Fixed mutation error dependency registration.
([ChilliCream/graphql-platform#6674)
- Fixed issue with default values on mutations.
([ChilliCream/graphql-platform#6776)
- Fixed CostAttribute multiplier path signature.
([ChilliCream/graphql-platform#6777)
- Fixed issue that caused the tag directive to be ignored.
([ChilliCream/graphql-platform#6746)
- Fixed broken postgres tests
([ChilliCream/graphql-platform#6779)
- Fixed Keyed Services
([ChilliCream/graphql-platform#6782)
- Fixed Tag Composition Tooling
([ChilliCream/graphql-platform#6783)
- EF Core middleware must check for IAsyncEnumerable.
([ChilliCream/graphql-platform#6784)

**Full Changelog**:
ChilliCream/graphql-platform@13.7.0...13.8.0-preview.8

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 10pm every weekday,every
weekend,before 5am every weekday" in timezone Europe/Berlin, Automerge -
At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/orso-co/Orso.Arpa.Api).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@PascalSenn PascalSenn mentioned this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants