Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed argument naming conventions for mutation conventions. #6705

Merged

Conversation

PHILLIPS71
Copy link
Contributor

  • adds failing test to outline issue when enabling mutation conventions + custom naming conventions

Relates to #3088

@glen-84

This comment was marked as resolved.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (6965960) 78.98% compared to head (7706e2a) 63.92%.
Report is 76 commits behind head on main.

Files Patch % Lines
...rization.Opa/Request/DefaultQueryRequestFactory.cs 0.00% 3 Missing ⚠️
...Abstractions/Serialization/Utf8JsonWriterHelper.cs 40.00% 3 Missing ⚠️
.../Transport.Http/GraphQLHttpEventStreamProcessor.cs 92.10% 3 Missing ⚠️
...AspNetCore/src/Transport.Http/GraphQLHttpClient.cs 71.42% 2 Missing ⚠️
...Core/Serialization/DefaultHttpResponseFormatter.cs 0.00% 1 Missing ⚠️
...pNetCore/src/Transport.Http/GraphQLHttpResponse.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6705       +/-   ##
===========================================
- Coverage   78.98%   63.92%   -15.07%     
===========================================
  Files        2903     2324      -579     
  Lines      139771   114624    -25147     
===========================================
- Hits       110397    73268    -37129     
- Misses      29374    41356    +11982     
Flag Coverage Δ
unittests 63.92% <80.88%> (-15.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PHILLIPS71

This comment was marked as resolved.

@michaelstaib michaelstaib self-requested a review November 17, 2023 12:06
@michaelstaib michaelstaib changed the title add test to cover mutation conventions + naming conventions Fixed argument naming conventions for mutation conventions. Nov 17, 2023
@michaelstaib michaelstaib merged commit f90fbaa into ChilliCream:main Nov 17, 2023
65 of 98 checks passed
michaelstaib added a commit that referenced this pull request Dec 11, 2023
Co-authored-by: Michael Staib <michael@chillicream.com>
renovate bot added a commit to orso-co/Orso.Arpa.Api that referenced this pull request Dec 22, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [HotChocolate.Abstractions](https://chillicream.com/)
([source](https://togithub.com/ChilliCream/graphql-platform)) | `13.7.0`
-> `13.8.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/HotChocolate.Abstractions/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/HotChocolate.Abstractions/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/HotChocolate.Abstractions/13.7.0/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/HotChocolate.Abstractions/13.7.0/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [HotChocolate.AspNetCore](https://chillicream.com/)
([source](https://togithub.com/ChilliCream/graphql-platform)) | `13.7.0`
-> `13.8.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/HotChocolate.AspNetCore/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/HotChocolate.AspNetCore/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/HotChocolate.AspNetCore/13.7.0/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/HotChocolate.AspNetCore/13.7.0/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [HotChocolate.AspNetCore.Authorization](https://chillicream.com/)
([source](https://togithub.com/ChilliCream/graphql-platform)) | `13.7.0`
-> `13.8.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/HotChocolate.AspNetCore.Authorization/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/HotChocolate.AspNetCore.Authorization/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/HotChocolate.AspNetCore.Authorization/13.7.0/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/HotChocolate.AspNetCore.Authorization/13.7.0/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [HotChocolate.Data](https://chillicream.com/)
([source](https://togithub.com/ChilliCream/graphql-platform)) | `13.7.0`
-> `13.8.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/HotChocolate.Data/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/HotChocolate.Data/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/HotChocolate.Data/13.7.0/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/HotChocolate.Data/13.7.0/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [HotChocolate.Data.EntityFramework](https://chillicream.com/)
([source](https://togithub.com/ChilliCream/graphql-platform)) | `13.7.0`
-> `13.8.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/HotChocolate.Data.EntityFramework/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/HotChocolate.Data.EntityFramework/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/HotChocolate.Data.EntityFramework/13.7.0/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/HotChocolate.Data.EntityFramework/13.7.0/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [HotChocolate.Types](https://chillicream.com/)
([source](https://togithub.com/ChilliCream/graphql-platform)) | `13.7.0`
-> `13.8.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/HotChocolate.Types/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/HotChocolate.Types/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/HotChocolate.Types/13.7.0/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/HotChocolate.Types/13.7.0/13.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>ChilliCream/graphql-platform
(HotChocolate.Abstractions)</summary>

###
[`v13.8.0`](https://togithub.com/ChilliCream/graphql-platform/releases/tag/13.8.0)

[Compare
Source](https://togithub.com/ChilliCream/graphql-platform/compare/13.7.0...13.8.0)

##### What's Changed

- Fixed issue with the fusion configuration rewriter.
([ChilliCream/graphql-platform#6670)
- Adds example for failing error interface
([ChilliCream/graphql-platform#6665)
- Set limit on serialized message size in Subscriptions.Postgres
([ChilliCream/graphql-platform#6678)
-   Fix JsonElement serialization for StrawberryShake
- Reworked JSON scalar usage with StrawberryShake.
([ChilliCream/graphql-platform#6683)
- Updated BananaCakePop Default Version
([ChilliCream/graphql-platform#6687)
- Make postgres subscription provider compatible with npgsql 8
([ChilliCream/graphql-platform#6686)
- Handle JsonElement JsonValueKind.Null when deserializing
([ChilliCream/graphql-platform#6481)
- Fixed Utf8JsonWriterHelper to not ignore null dictionary values
([ChilliCream/graphql-platform#6689)
- Fixed the ghost files in Rider when using strawberyy shake
([ChilliCream/graphql-platform#6693)
- Fixed dotnet version check filter non version output for Strawberry
Shake
([ChilliCream/graphql-platform#6699)
- Fixed argument naming conventions for mutation conventions.
([ChilliCream/graphql-platform#6705)
- Fixed cache pollution for in/nin filter expressions
([ChilliCream/graphql-platform#6711)
- Fixed large json read corruption
([ChilliCream/graphql-platform#6713)
- Fixed typo in Banana Cake Pop docs
([ChilliCream/graphql-platform#6715)
- Update open api schema snapshot to fix unit tests
([ChilliCream/graphql-platform#6708)
- Fixed array writer reset
([ChilliCream/graphql-platform#6719)
- \[maintenance] Empty type termination using semicolon.
[ChilliCream/graphql-platform#6725)
- Added apollo federation docs
([ChilliCream/graphql-platform#5791)
- Fixed example in docs
([ChilliCream/graphql-platform#6733)
- StrawberryShake documentation fixes
([ChilliCream/graphql-platform#6742)
- Adds more documentation for BCP
([ChilliCream/graphql-platform#6709)
- Avoid writing BOM in StrawberryShake Tools
([ChilliCream/graphql-platform#6751)
- Fixed transport layer byte-array handling.
([ChilliCream/graphql-platform#6763)
- Fixed SSE message corruption
([ChilliCream/graphql-platform#6642)
- Do not send omitted arguments with default values to subgraph
([ChilliCream/graphql-platform#6767)
- Fixed mutation error dependency registration.
([ChilliCream/graphql-platform#6674)
- Fixed issue with default values on mutations.
([ChilliCream/graphql-platform#6776)
- Fixed CostAttribute multiplier path signature.
([ChilliCream/graphql-platform#6777)
- Fixed issue that caused the tag directive to be ignored.
([ChilliCream/graphql-platform#6746)
- Fixed broken postgres tests
([ChilliCream/graphql-platform#6779)
- Fixed Keyed Services
([ChilliCream/graphql-platform#6782)
- Fixed Tag Composition Tooling
([ChilliCream/graphql-platform#6783)
- EF Core middleware must check for IAsyncEnumerable.
([ChilliCream/graphql-platform#6784)

**Full Changelog**:
ChilliCream/graphql-platform@13.7.0...13.8.0-preview.8

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 10pm every weekday,every
weekend,before 5am every weekday" in timezone Europe/Berlin, Automerge -
At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/orso-co/Orso.Arpa.Api).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@PascalSenn PascalSenn mentioned this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants