Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where the subscription stop message did have no effect. #3813

Merged
merged 2 commits into from
Jun 9, 2021

Conversation

michaelstaib
Copy link
Member

No description provided.

@michaelstaib michaelstaib changed the base branch from develop to main June 9, 2021 14:13
// in any case we will have a valid GraphQL result at this point that can be written
// to the HTTP response stream.
Debug.Assert(result is not null!, "No GraphQL result was created.");
await WriteResultAsync(context.Response, result, statusCode,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PascalSenn we did all the work on memory pooling.... but we never returned the results. Just for subscriptions the results were correctly disposed.

@michaelstaib michaelstaib merged commit aa6c592 into main Jun 9, 2021
@michaelstaib michaelstaib deleted the mst/subscription-stop branch June 9, 2021 14:31
@tvildo
Copy link
Contributor

tvildo commented Jun 9, 2021

It's working, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscriptions are not cancelled when connection is closed while waiting
2 participants