Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microwin returns unrelated error message when there's not enough space in C: #1740

Closed
acgzr opened this issue Mar 27, 2024 · 5 comments
Closed

Comments

@acgzr
Copy link

acgzr commented Mar 27, 2024

Describe the bug

This is a simple one. If there's not enough space in the C: drive, the install.wim/install.esd file doesn't (can't) get unpacked from the selected ISO during normal operation. Microwin interprets this as there being no install.wim/install.esd file in the first place, and returns an error message warning the user that the ISO probably is from a shady source because there's no install.wim/install.esd file.

To Reproduce

Make sure there's not enough space in C: to fit the ISO
Go to 'MicroWin'
Click on 'Select Windows ISO'
Select .iso file
Winutil Microwin error: install.wim/install.esd file doesn't exist in the image, this can happen when using modified ISOs. Please don't download images from shady sources, but only from Microsoft instead.

@blusewill
Copy link
Contributor

Well it's hard to tell that having enough resources or not.
But making a warning should be working for this.

@CodingWonders
Copy link
Contributor

Maybe we could detect the file size of the ISO file and the remaining space in the local drive since ISO files have no compression

@acgzr
Copy link
Author

acgzr commented Mar 30, 2024

Thank you for working on this one. I haven't had other noteworthy issues using Microwin, but it would be nice if it deleted its leftover files in the Temp folder automatically. I actually ran out of space in my C: drive (and found this bug) because I was processing a bunch of ISOs in a row and that Temp file got big quickly.

Anyways, just some extra info related to this issue. Thanks again for all your help putting this tool together and improving it continuously.

@CodingWonders
Copy link
Contributor

That change has also been added. Since the test branch was merged so quickly (due to AVs), you can now experience these changes in the main branch

@YusufKhalifadev
Copy link
Contributor

@acgzr
it has been fixed now in #1766
You should close the issue

@acgzr acgzr closed this as completed Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants