Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement model-view-controller architecture in HA components #5

Closed
ChristianKuehnel opened this issue Feb 12, 2018 · 1 comment
Closed

Implement model-view-controller architecture in HA components #5

ChristianKuehnel opened this issue Feb 12, 2018 · 1 comment
Labels
home assistant 🖥️ Related to Home Assistant functionality
Milestone
MVP for Home Assi...

Comments

@ChristianKuehnel
Copy link

the central component should poll the data and trigger the sensors to update their local state.

The individual sensors should not poll the data any more.
@ChristianKuehnel ChristianKuehnel added the home assistant 🖥️ Related to Home Assistant functionality label Feb 12, 2018
ChristianKuehnel added a commit to ChristianKuehnel/home-assistant that referenced this issue Feb 14, 2018
@ChristianKuehnel
major refactoring after major refactoring in bimmer_connected
c598612 
* Update are now triggered from BMWConnectedDriveVehicle.
* removed polling from sensor and device_tracker
* backend URL is not detected automatically based on current country
* vehicles are discovered automatically
* updates are async now

resolves:
* bimmerconnected/bimmer_connected#3
* bimmerconnected/bimmer_connected#5
MartinHjelmare pushed a commit to home-assistant/core that referenced this issue Feb 20, 2018
@ChristianKuehnel @MartinHjelmare
Add new component: BMW connected drive (#12277)
316eb59 
* first working version of BMW connected drive sensor

* extended coveragerc

* fixed blank line

* fixed pylint

* major refactoring after major refactoring in bimmer_connected

* Update are now triggered from BMWConnectedDriveVehicle.
* removed polling from sensor and device_tracker
* backend URL is not detected automatically based on current country
* vehicles are discovered automatically
* updates are async now

resolves:
* bimmerconnected/bimmer_connected#3
* bimmerconnected/bimmer_connected#5

* improved exception handing

* fixed static analysis findings

* fixed review comments from @MartinHjelmare

* improved startup, data is updated right after sensors were created.

* fixed pylint issue

* updated to latest release of the bimmer_connected library

* updated requirements-all.txt

* fixed comments from @MartinHjelmare

* calling self.update from async_add_job

* removed unused attribute "account"
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
home assistant 🖥️ Related to Home Assistant functionality
Projects
None yet
Milestone
MVP for Home Assistant
Development

No branches or pull requests
1 participant
@ChristianKuehnel