Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Self Registration does not look right #1464

Closed
DawoudIO opened this issue Nov 27, 2016 · 2 comments
Closed

Self Registration does not look right #1464

DawoudIO opened this issue Nov 27, 2016 · 2 comments
Assignees
@DawoudIO
Labels
bug
Milestone
2.4.0

Comments

@DawoudIO
Copy link
Contributor

http://demo.churchcrm.io/master/external/register/
@DawoudIO DawoudIO added the bug label Nov 27, 2016
@DawoudIO DawoudIO added this to the 2.4.0 milestone Nov 27, 2016
@DawoudIO DawoudIO mentioned this issue Nov 27, 2016
Merged
@DawoudIO DawoudIO self-assigned this Nov 27, 2016
@crossan007
Copy link
Contributor

it's fine on develop: http://demo.churchcrm.io/develop/external/register/

I haven't updated master in a while.

@DawoudIO DawoudIO reopened this Nov 28, 2016
@DawoudIO
Copy link
Contributor Author

still an issue, will close after merging #1470

DawoudIO added a commit that referenced this issue Nov 29, 2016
@DawoudIO
Fix Reg: #1464 (#1470)
e1542c0 
* cleanup of self::

* created

- new dto
- fixes bad URL for sRootPath
- throws error if invalid URL

* using new SystemURLs

* cleanup of $sRootPath

- using - SystemURLs
- removed sDocuemntRoot Var
- moved string cleanup into the SystemURLs class
- Checked for error from SystemURLs and dispaly error page

* fixed name

* Revert "cleanup of $sRootPath"

This reverts commit b287768.

* Revert "Revert "cleanup of $sRootPath""

This reverts commit b40362f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DawoudIO DawoudIO

Labels
bug
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
2 participants
@DawoudIO @crossan007