Fix Reg: #1464 #1470
Merged
Fix Reg: #1464 #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- using - SystemURLs - removed sDocuemntRoot Var - moved string cleanup into the SystemURLs class - Checked for error from SystemURLs and dispaly error page
crossan007
reviewed
Nov 28, 2016
| @@ -60,6 +62,13 @@ function mysql_failure($message) | |||
| exit(); | |||
| } | |||
| } | |||
| try { | |||
| SystemURLs::init($sRootPath, $URL, dirname(dirname(__FILE__))); | |||
crossan007
reviewed
Nov 28, 2016
| @@ -60,6 +62,13 @@ function mysql_failure($message) | |||
| exit(); | |||
| } | |||
| } | |||
| try { | |||
| SystemURLs::init($sRootPath, $URL, dirname(dirname(__FILE__))); | |||
| $sRootPath = SystemURLs::getRootPath(); | |||
There was a problem hiding this comment.
I assume this is only to maintain backward-compatibility without a full refactor?
|
I get this on a clean run :-(
|
|
are you sure this was from this PR? that error msg was from #1472 |
crossan007
reviewed
Nov 28, 2016
|
|
||
| private static function isValidRootPath() | ||
| { | ||
| if (stripos(self::$rootPath, "http") !== true ) { |
There was a problem hiding this comment.
What are you trying to do here? this function always returns false...
There was a problem hiding this comment.
we are making sure that the rootPath does not have a http in it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New DTO class for keeping URLs - fixed #1464