Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature remove ajax #102

Merged
merged 9 commits into from
Dec 24, 2015
Merged

Feature remove ajax #102

merged 9 commits into from
Dec 24, 2015

Conversation

DawoudIO
Copy link
Contributor

  • removed old Ajax dir/files
  • Dashboard has search by family and person
  • Side menu search works
  • Pledge is now using the new apis

@crossan007
Copy link
Contributor

I'm working on re-vamping the entire PledgeEditor process over at https://github.com/crossan007/CRM/tree/feature/Improve-Deposits and it'll cause some conflicts.

Would you rather merge this now, or wait for me to finish the other branch?

@DawoudIO
Copy link
Contributor Author

you can ignore my changes to that file once you are ready with yours...

$('[name=FamilyName]').val(ui.item.value);
$('[name=FamilyID]:eq(1)').val(ui.item.id);
$("#FamilyName").val(ui.item.value);
$("#FamilyID").val(ui.item.id);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line never actually sets the hidden field's value, thereby causing the payment submission to not reflect the family that donated.

tested on Google Chrome 47.0.2526.106(=

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the JQuery selector by ID doesn't work, but the JQuery selector by field name and :eq(1) does work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm i tested it in chrome dev tools... what browser are you using.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google Chrome 47.0.2526.106

@DawoudIO
Copy link
Contributor Author

since you are revamping this page, let me merge and you can override my changes.

@crossan007
Copy link
Contributor

Looks good now.

crossan007 added a commit that referenced this pull request Dec 24, 2015
@crossan007 crossan007 merged commit 3d89f4c into develop Dec 24, 2015
@DawoudIO DawoudIO deleted the feature/remove-ajax branch December 24, 2015 18:54
@DawoudIO DawoudIO modified the milestone: 2.0.0 Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants