-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature remove ajax #102
Feature remove ajax #102
Conversation
DawoudIO
commented
Dec 23, 2015
- removed old Ajax dir/files
- Dashboard has search by family and person
- Side menu search works
- Pledge is now using the new apis
- ReAdded order by fName - JSON Payload is now using standard names
I'm working on re-vamping the entire PledgeEditor process over at https://github.com/crossan007/CRM/tree/feature/Improve-Deposits and it'll cause some conflicts. Would you rather merge this now, or wait for me to finish the other branch? |
you can ignore my changes to that file once you are ready with yours... |
$('[name=FamilyName]').val(ui.item.value); | ||
$('[name=FamilyID]:eq(1)').val(ui.item.id); | ||
$("#FamilyName").val(ui.item.value); | ||
$("#FamilyID").val(ui.item.id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line never actually sets the hidden field's value, thereby causing the payment submission to not reflect the family that donated.
tested on Google Chrome 47.0.2526.106(=
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the JQuery selector by ID doesn't work, but the JQuery selector by field name and :eq(1) does work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm i tested it in chrome dev tools... what browser are you using.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Google Chrome 47.0.2526.106
since you are revamping this page, let me merge and you can override my changes. |
Looks good now. |