Improve Cart - Use Client Side Code #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Apply fixes from StyleCI
|
I'll test cart usage and see if I see any issues... If all good I'll merge and we can fix bugs as we find them. |
|
is this ready? |
|
the code looks good, a few feedback while I like the shaky cart, when you are on a long list and add the person to cart, it will take you to the top and lose your spot on the list. |
|
Person/Family view large add to cart are not affected by the cart status |
DawoudIO
approved these changes
Nov 23, 2017
|
not sure it fixes #2466 |
|
While it does not provide a "Add all family members to group" button, the process of adding the family to the cart, and then adding that cart to a group is greatly simplified and can be done without leaving the family view page. I'd argue that #2466 is satisfied by these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Cart - Use Client Side Code
Merge after #2944
Shared JS interactions with server are moved out of page-specific files into CRMJSOM (CRM JavaScript Object Moded) API.
Cart interactions are made via CRMJSOM: add, empty.
Fix group interactions with cart
closes: #2474
closes: #2463
closes: #2462
closes: #2466
closes: #2465
helps with: #2263