Add Person Social Fields #3325
Merged
Add Person Social Fields #3325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned Apply fixes from StyleCI
|
So this adds the fields but does not use them. Why is facebook id not name as each Facebook user has a known URL/username |
MVP ;-)
Not all FB users have an actual username. Additionally, the only way to access user image, over the new 2.0 API is with FBID. Accessing user properties by alphanumeric username has been deprecated / removed. snarfed/bridgy#350 |
|
is this ready for testing |
|
@DawoudIO after tests pass, this should be ready for you to take a look and/or merge |
DawoudIO
approved these changes
Nov 18, 2017
src/PersonEditor.php
Outdated
| </label> | ||
| <div class="input-group"> | ||
| <div class="input-group-addon"> | ||
| <i class="fa fa-envelope"></i> |
There was a problem hiding this comment.
why not used the icons for each?
|
tests are still failing please fix then merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1573
Adds social fields for people