Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail with Scala 2.11 due to different standard library names #22

Open
winitzki opened this issue Feb 11, 2018 · 6 comments
Open

Comments

@winitzki
Copy link
Collaborator

E.g. Either and List have different accessor names. The fix: make tests insensitive to these names.

@SethTisue
Copy link
Contributor

better to just drop 2.11 support at this point?

@winitzki
Copy link
Collaborator Author

I see no reason to drop 2.11 support. The failing tests depend on internal details of Scala standard library (e.g., the name of accessors in Either). Tests should not depend on that. Other than these tests, the library works exactly the same in all Scala versions. Is there a reason to prioritize this issue and have the tests fixed?

@SethTisue
Copy link
Contributor

These days, I encourage maintainers to take a "why keep it?" attitude to 2.11 rather than a "why drop it?" attitude. But you're in charge :-)

@winitzki
Copy link
Collaborator Author

Right now tests pass in 2.12 and 2.13. Some inessential tests fail in 2.11. Is this situation okay or should it be fixed asap?

@SethTisue
Copy link
Contributor

SethTisue commented Sep 28, 2021

Well I don't have an opinion about curryhoward in particular, but in general dropping old versions of things makes life easier and more pleasant for OSS maintainers and contributors (and that makes contributors easier to attract).

Regardless, some projects prioritize supporting as many users for as long as possible, even if it costs maintainer and contributor effort, and you can make arguments for that, too.

In Scala OSS generally a great many projects have already dropped 2.11, and some are starting to drop 2.12.

@winitzki
Copy link
Collaborator Author

In my job, we are still using 2.10, 2.11, and 2.12, while upgrading to 2.13 even for a few projects has been dragging on because we don't have enough scala programmers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants