-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests fail with Scala 2.11 due to different standard library names #22
Comments
better to just drop 2.11 support at this point? |
I see no reason to drop 2.11 support. The failing tests depend on internal details of Scala standard library (e.g., the name of accessors in Either). Tests should not depend on that. Other than these tests, the library works exactly the same in all Scala versions. Is there a reason to prioritize this issue and have the tests fixed? |
These days, I encourage maintainers to take a "why keep it?" attitude to 2.11 rather than a "why drop it?" attitude. But you're in charge :-) |
Right now tests pass in 2.12 and 2.13. Some inessential tests fail in 2.11. Is this situation okay or should it be fixed asap? |
Well I don't have an opinion about curryhoward in particular, but in general dropping old versions of things makes life easier and more pleasant for OSS maintainers and contributors (and that makes contributors easier to attract). Regardless, some projects prioritize supporting as many users for as long as possible, even if it costs maintainer and contributor effort, and you can make arguments for that, too. In Scala OSS generally a great many projects have already dropped 2.11, and some are starting to drop 2.12. |
In my job, we are still using 2.10, 2.11, and 2.12, while upgrading to 2.13 even for a few projects has been dragging on because we don't have enough scala programmers. |
E.g. Either and List have different accessor names. The fix: make tests insensitive to these names.
The text was updated successfully, but these errors were encountered: