Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --build-arg #5

Closed
FelixDuvalletKodiak opened this issue Jan 3, 2019 · 2 comments
Closed

Add support for --build-arg #5

FelixDuvalletKodiak opened this issue Jan 3, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@FelixDuvalletKodiak
Copy link

Some Dockerfiles contain arguments:

ARG SOME_ARG="default_value"

and are filled in during building: docker build --build-arg SOME_ARG=my_value

Can we add support for a list of build arguments in this orb?

@nihonjinrxs
Copy link

Was looking at this for a possible Hacktoberfest contribution, but it seems like maybe #8 solved it? Is that not true?

@lokst
Copy link
Contributor

lokst commented Sep 26, 2019

@nihonjinrxs You're right, the work done in #8 can be used to resolve this issue. Apologies for the confusion, and thanks for reaching out to clarify!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants