Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[semver:minor] Add support for pushing multiple tags at once #46

Merged
merged 1 commit into from
Apr 30, 2021
Merged

[semver:minor] Add support for pushing multiple tags at once #46

merged 1 commit into from
Apr 30, 2021

Conversation

danopia
Copy link
Contributor

@danopia danopia commented Apr 16, 2021

The docker orb already supports creating multiple tags at one go, so if you try this today, the build will pass while the push fails. This adds the same support to push, so one CircleCI job can build/push multiple tags.

I'd generally use this as so:

          tag: ${CIRCLE_SHA1},latest

I'm opening this PR without directly related ticket as per discussion on #8 (comment)

Based on CircleCI-Public/docker-orb#37 with a bit of CircleCI-Public/docker-orb#72

@danopia danopia requested a review from a team as a code owner April 16, 2021 15:27
@gmemstr
Copy link

gmemstr commented Apr 30, 2021

@danopia Thanks for the PR! Taking a look now, this definitely seems like a useful addition.

@gmemstr gmemstr changed the title Add support for pushing multiple tags at once [semver:minor] Add support for pushing multiple tags at once Apr 30, 2021
@gmemstr gmemstr merged commit 6b2d72f into CircleCI-Public:master Apr 30, 2021
@angeliski
Copy link

Hey @gmemstr Could you release that feature?

@danopia
Copy link
Contributor Author

danopia commented Mar 28, 2022

For closure, it looks like this got into a recent release and should be available in 0.15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants