Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When txHash is null that should throw an error instead of returning null #188

Open
mikozet opened this issue Apr 20, 2023 · 4 comments
Open
Labels

Comments

@mikozet
Copy link
Collaborator

mikozet commented Apr 20, 2023

Currently

return null;

Please verify after if code in myxogastria is adapted correctly in
https://github.com/CirclesUBI/circles-myxogastria/blob/8f57e2c05eb910b1e4f9893b7a46689e67495a1d/src/store/token/actions.js#L318

It might be that for time being we throw an error in myxogastrai when txHash is null

@louilinn
Copy link
Contributor

We might need to catch some error in the core as well. See this issue for context CirclesUBI/circles-myxogastria#589

@louilinn
Copy link
Contributor

louilinn commented Apr 25, 2023

Related Sentry issue: MYXOGASTRIA-PRODUCTION-FVC

When throwing errors in the core we should also make sure to include all relevant information in the TransferError. The transferErrors are logged to myxogastria https://github.com/CirclesUBI/circles-myxogastria/blob/2e5dfe99db31f0225bdef99ce5e1d89a76068dd8/src/views/SendConfirm.js#L143

@louilinn
Copy link
Contributor

Task includes to review transfer errors in the core in general and document. Once defined we need to also adjust the error messages in myxogastria: https://github.com/CirclesUBI/circles-myxogastria/blob/7e249fa31c206b90756803f66a2c0b8a7506c41c/locales/en.json#L342

@louilinn louilinn changed the title When txHash is null that should throw an error instead of returning null #662 When txHash is null that should throw an error instead of returning null Apr 25, 2023
@louilinn
Copy link
Contributor

Related to PR: CirclesUBI/circles-myxogastria#630
Remove catch in myxo afterwards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants